Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat] Httpjson v2 changes #23069

Merged
merged 1 commit into from
Dec 14, 2020
Merged

[Filebeat] Httpjson v2 changes #23069

merged 1 commit into from
Dec 14, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Dec 10, 2020

What does this PR do?

  • Initialize header and body on transform if not set
  • Avoid first page being '0'
  • Do not send empty events if root split has no values
  • Add option to reuse request body for pagination requests

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@marc-gr
Httpjson v2 changes:
0b11cad 
- Initialize header and body on transform if not set
- Avoid first page being '0'
- Do not send empty events if root split has no values
- Add option to reuse request body for pagination requests
@marc-gr marc-gr added enhancement Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. Team:Security-External Integrations labels Dec 10, 2020
@marc-gr marc-gr requested a review from a team December 10, 2020 15:16
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 10, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23069 opened

  • Start Time: 2020-12-10T15:17:43.589+0000

  • Duration: 46 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 2422
Skipped 261
Total 2683

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2422
Skipped 261
Total 2683

@marc-gr marc-gr merged commit 9db963e into elastic:master Dec 14, 2020
@marc-gr marc-gr deleted the httpjson_changes branch December 14, 2020 08:54
marc-gr added a commit to marc-gr/beats that referenced this pull request Dec 14, 2020
@marc-gr
Httpjson v2 changes: (elastic#23069)
5bafec2 
- Initialize header and body on transform if not set
- Avoid first page being '0'
- Do not send empty events if root split has no values
- Add option to reuse request body for pagination requests

(cherry picked from commit 9db963e)
@marc-gr marc-gr mentioned this pull request Dec 14, 2020
Merged
4 tasks
@marc-gr marc-gr added v7.11.0 and removed needs_backport PR is waiting to be backported to other branches. labels Dec 14, 2020
marc-gr added a commit that referenced this pull request Dec 14, 2020
@marc-gr
Httpjson v2 changes: (#23069) (#23097)
d15ec7f 
- Initialize header and body on transform if not set
- Avoid first page being '0'
- Do not send empty events if root split has no values
- Add option to reuse request body for pagination requests

(cherry picked from commit 9db963e)
@marc-gr marc-gr restored the httpjson_changes branch March 26, 2021 11:52
@marc-gr marc-gr deleted the httpjson_changes branch March 26, 2021 11:58
@marc-gr marc-gr restored the httpjson_changes branch March 26, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
enhancement Filebeat Filebeat v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marc-gr @elasticmachine @andrewkroh