-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Allow cisco/asa and cisco/ftd modules to override network directionality based off of zones #23068
Merged
andrewstucki
merged 6 commits into
elastic:master
from
andrewstucki:cisco-network-direction
Dec 10, 2020
Merged
[Filebeat] Allow cisco/asa and cisco/ftd modules to override network directionality based off of zones #23068
andrewstucki
merged 6 commits into
elastic:master
from
andrewstucki:cisco-network-direction
Dec 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…directionality based off of zones
andrewstucki
added
enhancement
Filebeat
Filebeat
ecs
Team:Security-External Integrations
labels
Dec 10, 2020
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Dec 10, 2020
Collaborator
leehinman
approved these changes
Dec 10, 2020
Since there's no way of overriding the config on a per golden file basis. Here's a diff to demonstrate this working: With the following configuration change diff --git a/x-pack/filebeat/module/cisco/ftd/manifest.yml b/x-pack/filebeat/module/cisco/ftd/manifest.yml
index 31eb9659a..6c07bdf33 100644
--- a/x-pack/filebeat/module/cisco/ftd/manifest.yml
+++ b/x-pack/filebeat/module/cisco/ftd/manifest.yml
@@ -25,7 +25,9 @@ var:
- name: internal_PREFIX
default: FTD
- name: external_zones
+ default: [ "output-zone" ]
- name: internal_zones
+ default: [ "input-zone" ]
ingest_pipeline: ../shared/ingest/asa-ftd-pipeline.yml
input: config/input.yml We see the following change: diff --git a/x-pack/filebeat/module/cisco/ftd/test/dns.log-expected.json b/x-pack/filebeat/module/cisco/ftd/test/dns.log-expected.json
index 093665fca..b6a5aa94f 100644
--- a/x-pack/filebeat/module/cisco/ftd/test/dns.log-expected.json
+++ b/x-pack/filebeat/module/cisco/ftd/test/dns.log-expected.json
@@ -74,6 +74,7 @@
"log.level": "alert",
"log.offset": 0,
"network.application": "dns client",
+ "network.direction": "outbound",
"network.iana_number": 17,
"network.protocol": "dns",
"network.transport": "udp", |
andrewstucki
pushed a commit
to andrewstucki/beats
that referenced
this pull request
Dec 10, 2020
…directionality based off of zones (elastic#23068) * [Filebeat] Allow cisco/asa and cisco/ftd modules to override network directionality based off of zones * Add changelog entry * Don't override categorization if no zone set * regenerate golden files (cherry picked from commit 76b7c8c)
6 tasks
andrewstucki
pushed a commit
that referenced
this pull request
Dec 10, 2020
…odules to override network directionality based off of zones (#23084) * [Filebeat] Allow cisco/asa and cisco/ftd modules to override network directionality based off of zones (#23068) * [Filebeat] Allow cisco/asa and cisco/ftd modules to override network directionality based off of zones * Add changelog entry * Don't override categorization if no zone set * regenerate golden files (cherry picked from commit 76b7c8c) * Fix up changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adopts the same logic as #22998 by classifying internal/external/inbound/outbound traffic based off of zones. The implementation is similar to #23066 in that the zone-based classification is off by default, since the cisco logs already classify inbound/outbound for you.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues