Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22874 to 7.x: use environment variables in install-service.ps1 template #22900

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented Dec 3, 2020

Cherry-pick of PR #22874 to 7.x branch. Original message:

What does this PR do?

Replaces C:\ProgramData with environment variable env:PROGRAMDATA in
the install-service.ps1 scripts.

Why is it important?

Follows best practice for determining locations on Windows.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

run install-service.ps1 on Windows machine

)

- replace hard coded C:\ProgramData with $env:PROGRAMDATA

(cherry picked from commit 3910e8b)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 3, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #22900 opened

  • Start Time: 2020-12-03T17:08:13.295+0000

  • Duration: 62 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 16829
Skipped 1398
Total 18227

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 16829
Skipped 1398
Total 18227

@leehinman leehinman merged commit 1872cb8 into elastic:7.x Dec 10, 2020
@leehinman leehinman deleted the backport_22874_7.x branch December 10, 2020 03:31
@zube zube bot removed the [zube]: Done label Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants