Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect OneMineRate metrics in Kafka module #22733

Merged
merged 3 commits into from
Dec 7, 2020
Merged

Collect OneMineRate metrics in Kafka module #22733

merged 3 commits into from
Dec 7, 2020

Conversation

gquintana
Copy link
Contributor

  • Bug

What does this PR do?

Collect OneMinuteRate metrics in Kafka broker metricset instead of MeanRate

Why is it important?

MeanRate is rate an average rate since Kafka startup.
In short it doesn't mean anything and doesn't shown Kafka current state.

Checklist

  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Use cases

Kafka monitoring

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 24, 2020
@gquintana gquintana mentioned this pull request Nov 24, 2020
Closed
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 24, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: jsoriano commented: jenkins run the tests please

  • Start Time: 2020-12-03T18:32:00.303+0000

  • Duration: 58 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 2312
Skipped 510
Total 2822

Steps errors 2

Expand to view the steps failures

Terraform Apply on x-pack/metricbeat/module/aws

  • Took 0 min 15 sec . View more details on here

Terraform Apply on x-pack/metricbeat/module/aws

  • Took 0 min 16 sec . View more details on here

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2312
Skipped 510
Total 2822

@andresrc andresrc added the Team:Services (Deprecated) Label for the former Integrations-Services team label Nov 24, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 24, 2020
@andresrc
Copy link
Contributor

andresrc commented Dec 1, 2020

@jsoriano can you take a look? would this be a breaking change?

@jsoriano
Copy link
Member

jsoriano commented Dec 1, 2020

@jsoriano can you take a look? would this be a breaking change?

Sure, taking a look. Generally speaking it would be a breaking change, but I agree that current behaviour is not very useful, so it can be considered more a bugfix. Also this metricset is in beta state, so no problem with this change.

@gquintana thanks a lot of this PR! Could you please add a changelog entry in CHANGELOG.next.asciidoc?

@jsoriano
Copy link
Member

jsoriano commented Dec 1, 2020

jenkins run the tests please

@jsoriano jsoriano self-assigned this Dec 1, 2020
jsoriano
jsoriano reviewed Dec 1, 2020
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, waiting for the changelog and CI and it would be ready to merge. Thanks!

metricbeat/module/kafka/broker/manifest.yml Show resolved Hide resolved
@jsoriano
Copy link
Member

jsoriano commented Dec 3, 2020

jenkins run the tests please

@gquintana
Copy link
Contributor Author

thanks @jsoriano for the changelog, you were faster than me

@jsoriano jsoriano merged commit 08a7586 into elastic:master Dec 7, 2020
@jsoriano jsoriano mentioned this pull request Dec 7, 2020
Merged
1 task
jsoriano pushed a commit to jsoriano/beats that referenced this pull request Dec 7, 2020
@gquintana @jsoriano
Collect OneMineRate metrics in Kafka module (elastic#22733)
f140585 
MeanRate is rate an average rate since Kafka startup, it doesn't
mean anything and doesn't shown Kafka current state.
OneMinuteRate is a better representation of current state.

(cherry picked from commit 08a7586)
jsoriano added a commit that referenced this pull request Dec 7, 2020
@jsoriano @gquintana
Collect OneMinuteRate metrics in Kafka module (#22733) (#22952)
cbffc87 
MeanRate is rate an average rate since Kafka startup, it doesn't
mean anything and doesn't shown Kafka current state.
OneMinuteRate is a better representation of current state.

(cherry picked from commit 08a7586)

Co-authored-by: Gerald Quintana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees

@jsoriano jsoriano

Labels
Team:Services (Deprecated) Label for the former Integrations-Services team v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In Metricbeat Kafka modules based on Jolokia, collect OneMinuteRate instead of MeanRate
4 participants
@gquintana @elasticmachine @andresrc @jsoriano