Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat][New Module] Snyk vulnerabilities and audit logs #22677

Merged
merged 17 commits into from
Dec 14, 2020

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Nov 19, 2020

What does this PR do?

Adds support for collecting found vulnerabilities and audit logs from the Snyk API.

Why is it important?

Adds support for new OOTB products to Filebeat.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 19, 2020
@P1llus
Copy link
Member Author

P1llus commented Nov 19, 2020

This PR is not fully ready yet for review. It requires the updates to the httpjson input, so the config template is not finalized, and the documentation needs to be updated.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 19, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #22677 updated

  • Start Time: 2020-12-14T10:05:44.789+0000

  • Duration: 43 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 5098
Skipped 570
Total 5668

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 5098
Skipped 570
Total 5668

@P1llus
Copy link
Member Author

P1llus commented Nov 20, 2020

jenkins test this

@P1llus P1llus marked this pull request as ready for review December 8, 2020 00:01
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@P1llus
Copy link
Member Author

P1llus commented Dec 10, 2020

the templating delimiters changed in the last minute, so do not merge yet, need to apply changes for #23056

@P1llus
Copy link
Member Author

P1llus commented Dec 14, 2020

The updates have now been pushed, some internal teams have already tested the module as well and its working fine. Might want to add some more ECS fields or testing after merge.

@marc-gr marc-gr merged commit 940e2e5 into elastic:master Dec 14, 2020
@P1llus P1llus deleted the filebeat_snyk_module branch December 14, 2020 12:31
marc-gr pushed a commit to marc-gr/beats that referenced this pull request Dec 14, 2020
…2677)

* filebeat Snyk module MVP initial commit

* initial commit for Snyk filebeat module

* adding timestamp exceptions to module test

* fixing field definition and updating timestamp field for audit

* stashing changes

* updating Snyk module to support httpjson v2 input and fixing some broken field mappings and parsing

* adding CHANGELOG entry

* cleaning up test data

* updating testdata

* removing duplicate entry in manifest

* stashing changes

* updating httpjson delimiters and adding the possibility to set first_interval

(cherry picked from commit 940e2e5)
marc-gr added a commit that referenced this pull request Dec 14, 2020
…23102)

* filebeat Snyk module MVP initial commit

* initial commit for Snyk filebeat module

* adding timestamp exceptions to module test

* fixing field definition and updating timestamp field for audit

* stashing changes

* updating Snyk module to support httpjson v2 input and fixing some broken field mappings and parsing

* adding CHANGELOG entry

* cleaning up test data

* updating testdata

* removing duplicate entry in manifest

* stashing changes

* updating httpjson delimiters and adding the possibility to set first_interval

(cherry picked from commit 940e2e5)

Co-authored-by: Marius Iversen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants