Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elastic Agent] Fix monitoring to adjust - to _ in monitoring data stream #22554

Merged
merged 1 commit into from
Nov 12, 2020
Merged

[Elastic Agent] Fix monitoring to adjust - to _ in monitoring data stream #22554

merged 1 commit into from
Nov 12, 2020

Conversation

blakerouse
Copy link
Contributor

What does this PR do?

Ensures that the name of the data stream for monitoring by Elastic Agent converts - to _.

Why is it important?

So the data stream can be split based on -. See #22551

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@blakerouse blakerouse self-assigned this Nov 11, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 11, 2020
@blakerouse blakerouse mentioned this pull request Nov 11, 2020
Closed
@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1396
Skipped 4
Total 1400

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22554 opened]

  • Start Time: 2020-11-11T19:30:30.313+0000

  • Duration: 21 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 1396
Skipped 4
Total 1400

michalpristas
michalpristas approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blakerouse blakerouse merged commit af709fe into elastic:master Nov 12, 2020
@blakerouse blakerouse deleted the agent-fix-log-endpoint-datastream branch November 12, 2020 12:47
This was referenced Dec 1, 2020
Closed
Merged
blakerouse added a commit to blakerouse/beats that referenced this pull request Dec 1, 2020
@blakerouse
Fix monitoring to adjust - to _ in monitoring. (elastic#22554)
b10c35b 
(cherry picked from commit af709fe)
blakerouse added a commit that referenced this pull request Dec 1, 2020
@blakerouse
Fix monitoring to adjust - to _ in monitoring. (#22554) (#22838)
6d0785f 
(cherry picked from commit af709fe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpristas michalpristas michalpristas approved these changes

Assignees

@blakerouse blakerouse

Labels
v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elastic Agent writes to the wrong data_stream
3 participants
@blakerouse @elasticmachine @michalpristas