Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] Fix filesystem types on Windows #22531

Merged
merged 4 commits into from
Nov 11, 2020
Merged

[Metricbeat] Fix filesystem types on Windows #22531

merged 4 commits into from
Nov 11, 2020

Conversation

andrewstucki
Copy link

@andrewstucki andrewstucki commented Nov 10, 2020 •
edited
Loading

What does this PR do?

Fixes the filesystem types that are populated in Metricbeat's filesystem metricset.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@andrewstucki andrewstucki added bug Metricbeat Metricbeat Team:Observability Team:Services (Deprecated) Label for the former Integrations-Services team labels Nov 10, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 10, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 10, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22531 updated]

  • Start Time: 2020-11-11T02:03:38.770+0000

  • Duration: 145 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 15899
Skipped 1239
Total 17138

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 10, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 15899
Skipped 1239
Total 17138

@andrewstucki andrewstucki merged commit 952435b into elastic:master Nov 11, 2020
@andrewstucki andrewstucki mentioned this pull request Nov 11, 2020
Merged
6 tasks
andrewstucki pushed a commit to andrewstucki/beats that referenced this pull request Nov 11, 2020
[Metricbeat] Fix filesystem types on Windows (elastic#22531)
ff11143 
* Fix filesystem types on Windows

* Update changelog

* clean up old dependencies

* Update license

(cherry picked from commit 952435b)
andrewstucki pushed a commit that referenced this pull request Nov 12, 2020
[Metricbeat] Fix filesystem types on Windows (#22531) (#22544)
015205f 
* Fix filesystem types on Windows

* Update changelog

* clean up old dependencies

* Update license

(cherry picked from commit 952435b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fearful-symmetry fearful-symmetry fearful-symmetry approved these changes

Assignees
No one assigned
Labels
bug Metricbeat Metricbeat Team:Services (Deprecated) Label for the former Integrations-Services team v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metricbeat] Filesystem Metricset: Inconsistent system.filesystem.type values on Windows
4 participants
@andrewstucki @elasticmachine @fearful-symmetry @andresrc