Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22213 to 7.x: Rename google-pubsub Filebeat input to gcp-pubsub #22499

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Cherry-pick #22213 to 7.x: Rename google-pubsub Filebeat input to gcp-pubsub #22499

merged 1 commit into from
Nov 10, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

Cherry-pick of PR #22213 to 7.x branch. Original message:

What does this PR do?

This PR is to rename google-pubsub input to gcp-pubsub input. This is a part of the renaming process to change googlecloud to gcp in both Metricbeat and Filebeat.

Warning log message is also added when user is using the old input name:

2020-10-28T13:54:08.841-0600    WARN    [gcp.pubsub]    gcppubsub/input.go:79   google-pubsub input name is deprecated, please use gcp-pubsub instead   {"pubsub_project": "elastic-observability", "pubsub_topic": "my-gcp-pubsub-topic-name", "pubsub_subscription": {"Name":"my-gcp-pubsub-subscription-name","NumGoroutines":1,"MaxOutstandingMessages":1000,"Create":true}}

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

This should not be a breaking change so both google-pubsub and gcp-pubsub input names should work.

  1. Test google-pubsub name:
filebeat.inputs:
- type: google-pubsub
  enabled: true
  project_id: elastic-observability
  topic: my-gcp-pubsub-topic-name
  subscription.name: my-gcp-pubsub-subscription-name
  credentials_file: "/Users/kaiyansheng/Desktop/elastic-observability-5537b831234a.json"
  1. Test gcp-pubsub name:
filebeat.inputs:
- type: gcp-pubsub
  enabled: true
  project_id: elastic-observability
  topic: my-gcp-pubsub-topic-name
  subscription.name: my-gcp-pubsub-subscription-name
  credentials_file: "/Users/kaiyansheng/Desktop/elastic-observability-5537b831234a.json"

Related issues

* Rename google-pubsub Filebeat input to gcp-pubsub

* change to gcp-pubsub input name in elastic-agent

* add warning log message for deprecated old input name

(cherry picked from commit 42428a8)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 9, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Nov 9, 2020
@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 5856
Skipped 573
Total 6429

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22499 opened]

  • Start Time: 2020-11-09T18:18:53.438+0000

  • Duration: 55 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 5856
Skipped 573
Total 6429

Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change looks good

@kaiyan-sheng kaiyan-sheng merged commit 59455a9 into elastic:7.x Nov 10, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_22213_7.x branch November 10, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team [zube]: In Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants