Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #21282 to 7.x: stop monitoring excluded paths #22486

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Nov 9, 2020

Cherry-pick of PR #21282 to 7.x branch. Original message:

What does this PR do?

If the files match the excluded pattern, recursiveWatcher does not emit events for them, as well as errors if any.

Why is it important?

This eliminates unnecessary warning logs for file paths that user intends to exclude.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

run test case TestRecursiveExcludedPaths

Related issues

@marc-gr marc-gr requested a review from a team as a code owner November 9, 2020 11:49
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 9, 2020
@marc-gr marc-gr requested a review from a team November 9, 2020 11:49
@elasticmachine
Copy link
Collaborator

❕ Flaky test report

No test was executed to be analysed.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 9, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #22486 updated

  • Start Time: 2020-12-01T13:47:34.352+0000

  • Duration: 26 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 456
Skipped 60
Total 516

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 456
Skipped 60
Total 516

@marc-gr marc-gr force-pushed the backport_21282_7.x branch 2 times, most recently from 7f1a32b to be8fcac Compare November 23, 2020 09:24
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-gr marc-gr force-pushed the backport_21282_7.x branch from be8fcac to b4480b9 Compare December 1, 2020 11:47
If the files match the excluded pattern, recursiveWatcher does not emit events for them, as well as errors if any.

(cherry picked from commit af8eedd)
@marc-gr marc-gr force-pushed the backport_21282_7.x branch from b4480b9 to 1ebdc56 Compare December 1, 2020 13:46
@marc-gr marc-gr merged commit 887aa12 into elastic:7.x Dec 1, 2020
@marc-gr marc-gr deleted the backport_21282_7.x branch December 1, 2020 14:15
@zube zube bot removed the [zube]: Done label Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants