Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove working in progress comment #22367

Merged
merged 2 commits into from
Nov 5, 2020
Merged

remove working in progress comment #22367

merged 2 commits into from
Nov 5, 2020

Conversation

Leaf-Lin
Copy link
Contributor

@Leaf-Lin Leaf-Lin commented Nov 3, 2020

I remove the TODO comment because it shouldn't be left in the 7.9 (current) version.

Same thing needs to be fixed in 7.10 and master.

@Leaf-Lin
remove working in progress comment
b0ba36a 
I remove the TODO comment because it shouldn't be left in the 7.9 (current) version.

Same thing needs to be fixed in 7.10 and master.
@Leaf-Lin Leaf-Lin requested a review from narph November 3, 2020 04:18
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 3, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 3, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22367 updated]

  • Start Time: 2020-11-04T23:46:32.350+0000

  • Duration: 9 min 46 sec

@andresrc andresrc requested a review from EamonnTP November 3, 2020 06:15
@andresrc andresrc added the Team:Docs Label for the Observability docs team label Nov 3, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-docs (Team:Docs)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 3, 2020
@EamonnTP
Copy link

EamonnTP commented Nov 3, 2020

Hi @narph Rather than removing this section, is there content relating to compatibility that should be added?

@narph
Copy link
Contributor

narph commented Nov 4, 2020

Hi @narph Rather than removing this section, is there content relating to compatibility that should be added?

@Leaf-Lin well spotted, @EamonnTP we do not have any information that could be relevant for compatibility in this case.

narph
narph reviewed Nov 4, 2020
View reviewed changes
Copy link
Contributor

@narph narph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will have to re-genreate the azure.asciidoc as well in this case. (mage fmt update)

@dedemorton
Copy link
Contributor

I pushed a commit that should fix the CI tests. The problem here is that you need to make the change in the source file under the _meta directory then run the update (make update or mage fmt update).

I noticed that the example tagging used markdown, so I fixed that, too.

@dedemorton dedemorton self-assigned this Nov 4, 2020
@dedemorton
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@EamonnTP
Copy link

EamonnTP commented Nov 5, 2020

Thanks @dedemorton

@dedemorton dedemorton merged commit f0bad21 into 7.9 Nov 5, 2020
@dedemorton dedemorton deleted the Leaf-Lin-patch-1 branch November 5, 2020 18:28
This was referenced Nov 5, 2020
Merged
Merged
dedemorton added a commit to dedemorton/beats that referenced this pull request Nov 5, 2020
@Leaf-Lin @dedemorton
remove working in progress comment (elastic#22367)
0351839 
* remove working in progress comment

I remove the TODO comment because it shouldn't be left in the 7.9 (current) version.

Same thing needs to be fixed in 7.10 and master.

* Run make update and fix example formatting

Co-authored-by: DeDe Morton <[email protected]>
dedemorton added a commit to dedemorton/beats that referenced this pull request Nov 5, 2020
@Leaf-Lin @dedemorton
remove working in progress comment (elastic#22367)
fbdda12 
* remove working in progress comment

I remove the TODO comment because it shouldn't be left in the 7.9 (current) version.

Same thing needs to be fixed in 7.10 and master.

* Run make update and fix example formatting

Co-authored-by: DeDe Morton <[email protected]>
dedemorton added a commit to dedemorton/beats that referenced this pull request Nov 5, 2020
@Leaf-Lin @dedemorton
remove working in progress comment (elastic#22367)
d0647c6 
* remove working in progress comment

I remove the TODO comment because it shouldn't be left in the 7.9 (current) version.

Same thing needs to be fixed in 7.10 and master.

* Run make update and fix example formatting

Co-authored-by: DeDe Morton <[email protected]>
@dedemorton dedemorton mentioned this pull request Nov 5, 2020
Merged
dedemorton added a commit that referenced this pull request Nov 5, 2020
@dedemorton @Leaf-Lin
remove working in progress comment (#22367) (#22451)
eb486da 
* remove working in progress comment

I remove the TODO comment because it shouldn't be left in the 7.9 (current) version.

Same thing needs to be fixed in 7.10 and master.

* Run make update and fix example formatting

Co-authored-by: DeDe Morton <[email protected]>

Co-authored-by: Leaf-Lin <[email protected]>
dedemorton added a commit that referenced this pull request Nov 5, 2020
@dedemorton @Leaf-Lin
remove working in progress comment (#22367) (#22450)
ef89f56 
* remove working in progress comment

I remove the TODO comment because it shouldn't be left in the 7.9 (current) version.

Same thing needs to be fixed in 7.10 and master.

* Run make update and fix example formatting

Co-authored-by: DeDe Morton <[email protected]>

Co-authored-by: Leaf-Lin <[email protected]>
dedemorton added a commit that referenced this pull request Nov 5, 2020
@dedemorton @Leaf-Lin
remove working in progress comment (#22367) (#22452)
0cdeaa2 
* remove working in progress comment

I remove the TODO comment because it shouldn't be left in the 7.9 (current) version.

Same thing needs to be fixed in 7.10 and master.

* Run make update and fix example formatting

Co-authored-by: DeDe Morton <[email protected]>

Co-authored-by: Leaf-Lin <[email protected]>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@Leaf-Lin @dedemorton
remove working in progress comment (elastic#22367)
c11320b 
* remove working in progress comment

I remove the TODO comment because it shouldn't be left in the 7.9 (current) version.

Same thing needs to be fixed in 7.10 and master.

* Run make update and fix example formatting

Co-authored-by: DeDe Morton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narph narph narph left review comments

@EamonnTP EamonnTP EamonnTP approved these changes

@bmorelli25 bmorelli25 bmorelli25 approved these changes

Assignees

@dedemorton dedemorton

@EamonnTP EamonnTP

Labels
Team:Docs Label for the Observability docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Leaf-Lin @elasticmachine @EamonnTP @narph @dedemorton @bmorelli25 @andresrc