[Filebeat][Fortinet] Fixing kv split for when assign-ip is not an IP and for date checking when eventtime is missing #22361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
6 tasks
leehinman
pushed a commit
to leehinman/beats
that referenced
this pull request
Nov 2, 2020
…and for date checking when eventtime is missing (elastic#22361) * fixing assignip and making sure it does not error on missing eventtime field * updating changelog (cherry picked from commit 120f931)
6 tasks
leehinman
added a commit
that referenced
this pull request
Nov 3, 2020
…and for date checking when eventtime is missing (#22361) (#22363) * fixing assignip and making sure it does not error on missing eventtime field * updating changelog (cherry picked from commit 120f931) Co-authored-by: Marius Iversen <[email protected]>
leehinman
pushed a commit
to leehinman/beats
that referenced
this pull request
Nov 3, 2020
…and for date checking when eventtime is missing (elastic#22361) * fixing assignip and making sure it does not error on missing eventtime field * updating changelog (cherry picked from commit 120f931)
leehinman
added a commit
that referenced
this pull request
Nov 3, 2020
…and for date checking when eventtime is missing (#22361) (#22364) * fixing assignip and making sure it does not error on missing eventtime field * updating changelog (cherry picked from commit 120f931) Co-authored-by: Marius Iversen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since the KV processor does typechecking while performing the splitting operations, it will fail if the assignIP field is of type string, even though it is removed later in the pipeline when its not in the correct format. This change moves the KV split to a temp field to bypass the datatype checking, and performs a check against the IP field before renaming the fields to its correct placement.
Why is it important?
Fixes an issue with KV in cases where eventtime is missing and assignip is not in the correct datatype.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.