Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Rename googlecloud module to gcp module #22214

Merged
merged 18 commits into from
Nov 25, 2020
Merged

[Filebeat] Rename googlecloud module to gcp module #22214

merged 18 commits into from
Nov 25, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Oct 27, 2020

What does this PR do?

This PR is to rename googlecloud module in Filebeat to gcp module.
In this PR:

  • rename googlecloud module name to gcp
  • added an alias to allow the old name googlecloud to continue working
  • keeping field names the same(googlecloud.*) till 8.0.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 27, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Oct 27, 2020
@kaiyan-sheng kaiyan-sheng added the Team:Platforms Label for the Integrations - Platforms team label Oct 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 27, 2020
@kaiyan-sheng kaiyan-sheng added the in progress Pull request is currently in progress. label Oct 27, 2020
@kaiyan-sheng
Copy link
Contributor Author

@jsoriano I added https://github.com/kaiyan-sheng/beats/blob/rename_googlecloud_fb/x-pack/filebeat/module/googlecloud/module.yml similar to apache2 -> apache. I thought this would avoid making this a breaking change. But when I ran ./filebeat modules list, I only see the new gcp module. So even with the googlecloud/module.yml, this will still be a breaking change?

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 27, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22214 updated]

  • Start Time: 2020-11-24T14:52:32.611+0000

  • Duration: 43 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 4502
Skipped 562
Total 5064

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 4502
Skipped 562
Total 5064

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 28, 2020

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 4503
Skipped 561
Total 5064

filebeat/docs/modules/gcp.asciidoc Outdated Show resolved Hide resolved
filebeat/docs/modules/gcp.asciidoc Outdated Show resolved Hide resolved
x-pack/filebeat/module/gcp/_meta/config.yml Show resolved Hide resolved
x-pack/filebeat/module/gcp/_meta/fields.yml Outdated Show resolved Hide resolved
x-pack/filebeat/module/gcp/audit/config/pipeline.js Outdated Show resolved Hide resolved
@kaiyan-sheng
Copy link
Contributor Author

CI failure doesn't seem to be related. I created a separate issue for it: #22561

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please add to the description that an alias was added to allow the old name to continue working. And can you please open an issue so that the detection-rules can account for the event.dataset change (see https://github.com/elastic/detection-rules/search?q=googlecloud).

@kaiyan-sheng
Copy link
Contributor Author

@andrewkroh Done, thank you for the review! Here is the issue: elastic/detection-rules#627

@kaiyan-sheng kaiyan-sheng merged commit 113afdc into elastic:master Nov 25, 2020
@kaiyan-sheng kaiyan-sheng deleted the rename_googlecloud_fb branch November 25, 2020 03:36
kaiyan-sheng added a commit that referenced this pull request Nov 25, 2020
…p module (#22747)

* [Filebeat] Rename googlecloud module to gcp module (#22214)


(cherry picked from commit 113afdc)

* run mage fmt update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Pull request is currently in progress. Team:Platforms Label for the Integrations - Platforms team v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants