-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Rename googlecloud module to gcp module #22214
[Filebeat] Rename googlecloud module to gcp module #22214
Conversation
Pinging @elastic/integrations-platforms (Team:Platforms) |
@jsoriano I added https://github.com/kaiyan-sheng/beats/blob/rename_googlecloud_fb/x-pack/filebeat/module/googlecloud/module.yml similar to apache2 -> apache. I thought this would avoid making this a breaking change. But when I ran |
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
x-pack/filebeat/module/gcp/firewall/test/rare.log-expected.json
Outdated
Show resolved
Hide resolved
CI failure doesn't seem to be related. I created a separate issue for it: #22561 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you please add to the description that an alias was added to allow the old name to continue working. And can you please open an issue so that the detection-rules can account for the event.dataset change (see https://github.com/elastic/detection-rules/search?q=googlecloud).
@andrewkroh Done, thank you for the review! Here is the issue: elastic/detection-rules#627 |
What does this PR do?
This PR is to rename
googlecloud
module in Filebeat togcp
module.In this PR:
googlecloud
module name togcp
googlecloud
to continue workinggooglecloud.*
) till 8.0.Checklist
I have commented my code, particularly in hard-to-understand areasCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues