Cherry-pick #21835 to 7.x: Use symlink path for reexecutions #22100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #21835 to 7.x branch. Original message:
What does this PR do?
This PR initiates reexec manager with the path to symlink instead of
os.Executable
which might point to actual executable even if executed using symlink. This behavior leads to reexecing into same binary/version even after upgrade is done.Tested on linux/windows.
This happens on some OSes as behavior differs in evaluating symlinks. Some refer to symlink file as a process executable some follow symlink and refer to an actual executable.
This is visible during upgrade when upgrade is successfully finished but after reboot it boots up same process (visible as version unchanged in fleet UI).
Why is it important?
Upgrade scenario
Fixes: #21935
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.