Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #21628 to 7.10: [Elastic Agent] Fix issue where inputs without processors defined would panic #21716

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Cherry-pick #21628 to 7.10: [Elastic Agent] Fix issue where inputs without processors defined would panic #21716

merged 1 commit into from
Oct 13, 2020

Conversation

blakerouse
Copy link
Contributor

Cherry-pick of PR #21628 to 7.10 branch. Original message:

What does this PR do?

Fixes issue where inputs without processors defined would panic when promoting processors from a dynamic provider.

Why is it important?

So using a dynamic provider on an input without any processors doesn't panic.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@blakerouse
[Elastic Agent] Fix issue where inputs without processors defined wou…
663a0ca 
…ld panic (elastic#21628)

* Fix elastic#21581.

* Add changelog entry.

* Add test for processors as a map.

(cherry picked from commit f3d18f9)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 12, 2020
@blakerouse blakerouse self-assigned this Oct 12, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21716 opened]

  • Start Time: 2020-10-12T14:08:08.141+0000

  • Duration: 47 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 1390
Skipped 4
Total 1394

@ph ph requested a review from michalpristas October 13, 2020 18:56
ph
ph approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM backport

@blakerouse blakerouse merged commit 84cea5b into elastic:7.10 Oct 13, 2020
@blakerouse blakerouse deleted the backport_21628_7.10 branch October 13, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph ph ph approved these changes

@michalpristas michalpristas Awaiting requested review from michalpristas

Assignees

@blakerouse blakerouse

Labels
backport [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blakerouse @elasticmachine @ph