[Filebeat] Copy tag names from MISP data into event #21664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
💚 CLA has been signed |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
botelastic
bot
removed
the
needs_team
andrewkroh
requested changes
Oct 8, 2020
There was a problem hiding this comment.
Thanks @hungnguyen-elastic
- Please add a JSON event to the test directory that contains this
Tagfield. - Add an entry to the CHANGELOG.next.asciidoc file under the Added/Filebeat section.
- Update the golden test files (
cd x-pack/filebeat; GENERATE=true PYTEST_ADDOPTS="-k misp" mage -v pythonIntegTest). If you have trouble we can do this step.
andrewkroh
force-pushed
the
adding_tags_conversion
branch
from
a1e5d46 to
a1fdbe2
Compare
For each tag in the MISP data copy the name attribute into the `tags` array.
andrewkroh
force-pushed
the
adding_tags_conversion
branch
from
a1fdbe2 to
3311ec4
Compare
andrewkroh
changed the title
andrewkroh
added
the
needs_backport
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
andrewkroh
approved these changes
Oct 30, 2020
6 tasks
andrewkroh
removed
the
needs_backport
andrewkroh
pushed a commit
to andrewkroh/beats
that referenced
this pull request
Oct 30, 2020
For each tag in the MISP data copy the name attribute into the `tags` array. (cherry picked from commit 1933672)
|
Thanks @andrewkroh |
andrewkroh
added a commit
that referenced
this pull request
Nov 2, 2020
For each tag in the MISP data copy the name attribute into the `tags` array. (cherry picked from commit 1933672) Co-authored-by: hungnguyen-elastic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the code to convert MISP tags to Elastic event Tags. This will open up automation opportunity in Elastic from MISP.
Why is it important?
This will open up automation opportunity in Elastic from MISP. This also can allow threat content engineers to create threat matching or SIEM signal rules based on the MISP tags that are now added to the Elastic event through the MISP module
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.