Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] sync with recent changes in zeek package #21155

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

leehinman
Copy link
Contributor

What does this PR do?

Syncs changes made in zeek package with zeek module

  • always attempt community_id processor
  • dnp3 reorder pipeline to be same as package

Why is it important?

Filebeat module and package should be the same.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

TESTING_FILEBEAT_MODULES=zeek mage -v pythonIntegTest

@leehinman leehinman added enhancement Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. Team:SIEM labels Sep 18, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 18, 2020
- always attempt community_id processor
- dnp3 reorder pipeline to be same as package
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21155 opened]

  • Start Time: 2020-09-18T03:23:22.392+0000

  • Duration: 62 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 2497
Skipped 388
Total 2885

@leehinman leehinman merged commit 1932f9f into elastic:master Sep 18, 2020
leehinman added a commit to leehinman/beats that referenced this pull request Sep 18, 2020
- always attempt community_id processor
- dnp3 reorder pipeline to be same as package

(cherry picked from commit 1932f9f)
@leehinman leehinman added v7.10.0 and removed needs_backport PR is waiting to be backported to other branches. labels Sep 18, 2020
leehinman added a commit that referenced this pull request Sep 28, 2020
- always attempt community_id processor
- dnp3 reorder pipeline to be same as package

(cherry picked from commit 1932f9f)
@leehinman leehinman deleted the zeek_sync branch October 5, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants