Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #21047 to 7.x: [Elastic Agent] Fix loggers in composable module. #21053

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

blakerouse
Copy link
Contributor

Cherry-pick of PR #21047 to 7.x branch. Original message:

What does this PR do?

Fixes issue where logger.New was being used in the new composable module. This was creating a new logger instead of using application created logger. Providers are updated to take a logger, that is already named correctly.

Why is it important?

So logging works correctly.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 10, 2020
@blakerouse blakerouse self-assigned this Sep 10, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21053 opened]

  • Start Time: 2020-09-10T13:28:21.437+0000

  • Duration: 37 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 2081
Skipped 6
Total 2087

Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport lgtm

@blakerouse blakerouse merged commit de26878 into elastic:7.x Sep 10, 2020
@blakerouse blakerouse deleted the backport_21047_7.x branch September 10, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants