Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #21004 to 7.x: [Filebeat][Sophos] Docs YAML example for serial number mapping fixes #21009

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Sep 7, 2020

Cherry-pick of PR #21004 to 7.x branch. Original message:

What does this PR do?

The example config and documentation on serial number mapping was in the wrong format, causing confusion

Why is it important?

Give correct default values to users that utilizes the module

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 7, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21009 opened]

  • Start Time: 2020-09-07T14:24:55.927+0000

  • Duration: 54 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 5558
Skipped 833
Total 6391

@marc-gr marc-gr merged commit a6eafc8 into elastic:7.x Sep 8, 2020
@marc-gr marc-gr deleted the backport_21004_7.x branch September 8, 2020 07:53
@zube zube bot removed the [zube]: Done label Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants