Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #20736 to 7.9: Fill cloud.account.name with accountID if account alias doesn't exist #20835

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Cherry-pick #20736 to 7.9: Fill cloud.account.name with accountID if account alias doesn't exist #20835

merged 2 commits into from
Aug 31, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Aug 27, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #20736 to 7.9 branch. Original message:

This PR is to make sure cloud.account.name is not empty even when account alias/name does not exist. This is required because dashboards for aws module requires cloud.account.name as a filter.

@kaiyan-sheng
Fill cloud.account.name with accountID if account alias doesn't exist (…
64e5504 
…#20736)

* Fill cloud.account.name with accountID if account alias doesn't exist

(cherry picked from commit d2a0999)
@kaiyan-sheng kaiyan-sheng added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Aug 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 27, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Aug 27, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20835 opened]

  • Start Time: 2020-08-27T19:17:00.287+0000

  • Duration: 42 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 768
Skipped 72
Total 840

@kaiyan-sheng kaiyan-sheng merged commit 80db33a into elastic:7.9 Aug 31, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_20736_7.9 branch August 31, 2020 13:29
@zube zube bot removed the [zube]: Done label Nov 30, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@kaiyan-sheng
Cherry-pick elastic#20736 to 7.9: Fill cloud.account.name with accoun…
f35671b 
…tID if account alias doesn't exist (elastic#20835)

* Fill cloud.account.name with accountID if account alias doesn't exist (elastic#20736)

* Fill cloud.account.name with accountID if account alias doesn't exist

(cherry picked from commit bae7b38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narph narph narph approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaiyan-sheng @elasticmachine @narph