Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #20565 to 7.x: [Filebeat][Cisco Module] Adding various smaller hotfixes related to github issues #20767

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Cherry-pick #20565 to 7.x: [Filebeat][Cisco Module] Adding various smaller hotfixes related to github issues #20767

merged 1 commit into from
Aug 31, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Aug 25, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #20565 to 7.x branch. Original message:

What does this PR do?

This PR is a try to resolve some commonly reported issues and requests, together with a few small hotfixes, new testlog cases to catch these issues and generated new golden files for existing logs.

Overview of the changes:

  • Copies observer related information into the different observer fields but leaves the original fields for now to not break anything.
  • Fixes conditions around source+destination nat mapping, since a port can be nat'ed without a new IP for example.
  • Apply fixes for various github issues, see related issues below.
  • Apply support for new message_ids related to various github issues, see related issues below.
  • Move certain dissect to grok to support various message formats.

Why is it important?

Resolves variously reported issues about the ingest pipelines and adds support for more message fields.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@P1llus @marc-gr
[Filebeat][Cisco Module] Adding various smaller hotfixes related to g…
a3d46b2 
…ithub issues (elastic#20565)

* applying fixes to existing message_ids, adding support for new message_ids, fixing nat mapping and a few more

* adding the last missing fields

* updating changelog

* mage fmt update

* Updating test data to be a bit more realistic instead of just localhost

(cherry picked from commit 3f025e1)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 25, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20767 opened]

  • Start Time: 2020-08-25T07:34:14.820+0000

  • Duration: 57 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 5553
Skipped 830
Total 6383

@marc-gr marc-gr merged commit ba36bfb into elastic:7.x Aug 31, 2020
@marc-gr marc-gr deleted the backport_20565_7.x branch August 31, 2020 10:34
@zube zube bot removed the [zube]: Done label Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriansr adriansr adriansr approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marc-gr @elasticmachine @adriansr @P1llus