Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #20610 to 7.x: Heartbeat: move configuration of common input setting to the runner factory #20718

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

urso
Copy link

@urso urso commented Aug 20, 2020

Cherry-pick of PR #20610 to 7.x branch. Original message:

  • Bug

What does this PR do?

This changes moves the configuration of common input settings like
processors, fields, tags to the runner factory (similar to filebeat).

The settings index, pipeline, and dataset have been added as generic
settings to all monitors.

Why is it important?

Add missing settings index and pipeline to heartbeat monitors.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Add custom index/pipeline setting and send event to console output. If index/pipeline are configured, they can be read from the @metadata object.

Related issues

@urso urso requested a review from a team as a code owner August 20, 2020 18:26
@urso urso added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels Aug 20, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 20, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20718 opened]

  • Start Time: 2020-08-20T18:27:46.241+0000

  • Duration: 40 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 1216
Skipped 16
Total 1232

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urso urso merged commit dcc316a into elastic:7.x Aug 21, 2020
@urso urso deleted the backport_20610_7.x branch August 21, 2020 16:40
@zube zube bot removed the [zube]: Done label Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants