Cherry-pick #20226 to 7.x: [Filebeat][httpjson] Convert httpjson input to a v2 input #20702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
removed
the
needs_team
marc-gr
force-pushed
the
backport_20226_7.x
branch
from
c6729e9 to
891a01d
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
|
This #20704 needs to be merged first |
leehinman
approved these changes
Aug 20, 2020
) * Convert httpjson input to a v2 cursor input * Add CHANGELOG entry * Fix format errors * Convert to stateless input and refactor: - Paginator takes care of requesting next page info - Rate limiter takes care of rate limiting requests - Date cursor takes care of keeping track of cursor state * Remove python tests * Do not fail if there is no next page * Refactor go integration tests to work with v2 input * Do suggested changes to input and tests * Update time.Periodic call with error return * Change test duration values * Sepparate sync test case * Create custon url config type * Change input.Run comment * Change input.Run to only return on context cancellation * Remove all usages of pkg/errors (cherry picked from commit 929e838)
marc-gr
force-pushed
the
backport_20226_7.x
branch
from
891a01d to
fda732d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #20226 to 7.x branch. Original message:
What does this PR do?
Converts httpjson input to the new v2 stateless input.
Why is it important?
Several modules rely on httpjson input, and would benefit a lot from the new v2 cursor feature that keeps persistence of a cursor between restarts.
This change moves httpjson input to new v2 input, preparing to be able to implement the cursor persistence state in a following change.
Checklist
- [] I have made corresponding changes to the documentation- [] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Relates to #19486