Cherry-pick #20564 to 7.x: [Winlogbeat] Set event.outcome based on raw keyword value #20611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #20564 to 7.x branch. Original message:
What does this PR do?
Set the event.outcome value if the event contains the "audit failure" or "audit success" keywords.
The
Keywords
value in the XML is a hex value where each bit can represent a keyword. So thischecks if the audit success or audit failure bits are set then adds
event.outcome
as either"success" or "failure".
I removed similar logic from the Security module since it is now redundant. That logic was based
on string matching of the keyword name (rather than number) so it had problems when the OS
language was not English.
Why is it important?
Fixes
event.outcome
for non-English based Windows systems.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues