Cherry-pick #20564 to 7.x: [Winlogbeat] Set event.outcome based on raw keyword value #20611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
removed
the
needs_team
Set the event.outcome value if the event contains the "audit failure" or "audit success" keywords. The `Keywords` value in the XML is a hex value where each bit can represent a keyword. So this checks if the audit success or audit failure bits are set then adds `event.outcome` as either "success" or "failure". I removed similar logic from the Security module since it is now redundant. That logic was based on string matching of the keyword name (rather than number) so it had problems when the OS language was not English. Fixes elastic#20079 (cherry picked from commit 16ea8e2)
andrewkroh
force-pushed
the
backport_20564_7.x
branch
from
8898abc to
f28dc90
Compare
leehinman
approved these changes
Aug 14, 2020
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
andrewkroh
force-pushed
the
backport_20564_7.x
branch
from
2b0d6f1 to
5c57207
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #20564 to 7.x branch. Original message:
What does this PR do?
Set the event.outcome value if the event contains the "audit failure" or "audit success" keywords.
The
Keywordsvalue in the XML is a hex value where each bit can represent a keyword. So thischecks if the audit success or audit failure bits are set then adds
event.outcomeas either"success" or "failure".
I removed similar logic from the Security module since it is now redundant. That logic was based
on string matching of the keyword name (rather than number) so it had problems when the OS
language was not English.
Why is it important?
Fixes
event.outcomefor non-English based Windows systems.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues