Change cluster_ip field from ip to keyword #20571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismark <[email protected]>
ChrsMark
added
review
needs_backport
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
added
needs_team
Signed-off-by: chrismark <[email protected]>
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Aug 14, 2020
(cherry picked from commit 2ce0ab0)
ChrsMark
removed
the
needs_backport
|
Should we also backport this to 7.9 as a bug fix? |
ChrsMark
added a commit
that referenced
this pull request
Aug 14, 2020
I wouldn't consider it as a clear "bugfix" and hence I would prefer to not mix it with |
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the type of
cluster_ipfield ofstate_servicemetricset ofkubernetesMetricbeat module fromiptokeyword.Why is it important?
cluster_ipcan come with a value likeNonewhich is meaningful in Kubernetes networking. We need to change the type of this filed so as to be possible to index such values.Related issues