Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #20390 to 7.x: [Filebeat] fix event.type have incorrect value in system/syslog #20518

Merged
merged 2 commits into from
Aug 11, 2020

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented Aug 10, 2020

Cherry-pick of PR #20390 to 7.x branch. Original message:

What does this PR do?

In Filebeat system/syslog fileset change event.type = event to
event.kind = event

Why is it important?

"event" is not an allowed value for event.type in ECS.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

TESTING_FILEBEAT_MODULES=system mage -v pythonIntegTest

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 10, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 10, 2020
event.type was being set to event.  event is not one of the allowed
values for event.type in ECS.  Changing field to event.kind, where
event is an allowed value.

Closes elastic#20365

(cherry picked from commit 6843c55)
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20518 opened]

  • Start Time: 2020-08-10T14:55:55.065+0000

  • Duration: 56 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 5504
Skipped 824
Total 6328

@leehinman leehinman merged commit 3035154 into elastic:7.x Aug 11, 2020
@leehinman leehinman deleted the backport_20390_7.x branch October 5, 2020 19:06
@zube zube bot removed the [zube]: Done label Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants