-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat][nosetests] Printing error message when test_modules.py returns an error message from ES #20460
Merged
jsoriano
merged 2 commits into
elastic:master
from
P1llus:filebeat_test_add_errormessage
Aug 6, 2020
Merged
[Filebeat][nosetests] Printing error message when test_modules.py returns an error message from ES #20460
jsoriano
merged 2 commits into
elastic:master
from
P1llus:filebeat_test_add_errormessage
Aug 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/integrations (Team:Integrations) |
Pinging @elastic/siem (Team:SIEM) |
Collaborator
ChrsMark
reviewed
Aug 6, 2020
ChrsMark
reviewed
Aug 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just one minor suggestion.
jsoriano
approved these changes
Aug 6, 2020
ChrsMark
approved these changes
Aug 6, 2020
jsoriano
pushed a commit
to jsoriano/beats
that referenced
this pull request
Aug 6, 2020
…urns an error message from ES (elastic#20460) (cherry picked from commit f3fe010)
5 tasks
jsoriano
added a commit
that referenced
this pull request
Aug 6, 2020
…urns an error message from ES (#20460) (#20472) (cherry picked from commit f3fe010) Co-authored-by: Marius Iversen <[email protected]>
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
…urns an error message from ES (elastic#20460)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When working a lot with pipelines and continously run nosetests, if one of the test logs for a module returns an error it only prints the whole JSON. In large documents trying to find the error message over and over again can be tedious.
This PR adds a second line, printing only the error message as well.
Is this something we could add in? Would it break any sort of other tests that might expect a specific amount of lines back?
Why is it important?
Quality of life addition.
Checklist
- [ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Example output with the changes: