-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add host inventory metrics to googlecloud compute metricset #20391
Conversation
Pinging @elastic/integrations-platforms (Team:Platforms) |
}, | ||
"provider": "googlecloud" | ||
}, | ||
"cloud.availability_zone": "us-central1-a", | ||
"cloud.availability_zone": "asia-northeast1-b", | ||
"cloud.region": "asia-northeast1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to change here, just thinking loud. It might be interesting to have cloud-agnostic common values for regions. So a user can more easily group metrics coming from asia-northeast1
in GCP, and ap-northeast-1
in AWS.
Imagine for example being able to ingest with something like this metadata:
"cloud.region": {
"name": "asia-northeast1",
"area": "asia-pacific",
"country": "japan",
"city": "tokyo",
}
And if it were ingested from AWS:
"cloud.region": {
"name": "ap-northeast-1",
"area": "asia-pacific",
"country": "japan",
"city": "tokyo",
}
Not sure if cloud providers have APIs for this information.
Though maybe for that we can add geodata through an ingest pipeline in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsoriano Yeah good point! Different cloud has different names for regions. I don't see a specific API for GCP though but I think the geoip processor should be sufficient if we see good use cases in the future!
…20391) * Add host inventory metrics to googlecloud compute metricset
What does this PR do?
Why is it important?
This PR is to add proposed host common fields into
compute
metricset:Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
googlecloud
module:./metricbeat modules enable googlecloud
modules.d/googlecloud.yml
to only includecompute
metricset:3.Change add_host_metadata processor config in metricbeat.yml file:
compute
metricset and includes fields listed above.