-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #20084 to 7.9: Fix terminating pod autodiscover issue #20193
Conversation
(cherry picked from commit b561047)
Pinging @elastic/integrations-platforms (Team:Platforms) |
CHANGELOG.next.asciidoc
Outdated
@@ -89,6 +89,21 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d | |||
- Fix goroutine leak and Elasticsearch output file descriptor leak when output reloading is in use. {issue}10491[10491] {pull}17381[17381] | |||
- Fix Elasticsearch license endpoint URL referenced in error message. {issue}17880[17880] {pull}18030[18030] | |||
- Change `decode_json_fields` processor, to merge parsed json objects with existing objects in the event instead of fully replacing them. {pull}17958[17958] | |||
- [Autodiscover] Check if runner is already running before starting again. {pull}18564[18564] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra changelogs here 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ---------------------- Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
💔 Tests FailedExpand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ----------------------
--------------------- >> end captured stdout << ---------------------- Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
Cherry-pick of PR #20084 to 7.9 branch. Original message:
What does this PR do?
This addition handles the case when a Pod is in
Terminating
phase.In this case the pod is neither
PodSucceeded
norPodFailed
andhence requires special handling.
In this, we check all Pod's containers' statuses and if we find a at least
one still running we ignore this update event. With this, we make sure
that all containers are stopped before stopping Filebeat.
Why is it important?
To collect any leftover logs when the pod is going in Terminating state.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Use replication steps of #17396 (comment) and expect to see that the issue is fixed. The screenshot below provides the fixed case.
Related issues
Screenshots