Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Manager] Fix failing unit tests on windows #20127

Merged
merged 4 commits into from
Jul 23, 2020
Merged

[Ingest Manager] Fix failing unit tests on windows #20127

merged 4 commits into from
Jul 23, 2020

Conversation

michalpristas
Copy link
Contributor

What does this PR do?

Fixes failures of action store on windows due to unclosed readers across the codebase.

Why is it important?

To have action store work properly.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Fixes: #19919

@michalpristas michalpristas added bug review needs_backport PR is waiting to be backported to other branches. Team:Ingest Management Ingest Management:beta1 Group issues for ingest management beta1 labels Jul 22, 2020
@michalpristas michalpristas self-assigned this Jul 22, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 22, 2020
@botelastic
Copy link

botelastic bot commented Jul 22, 2020

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 22, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20127 updated]

  • Start Time: 2020-07-22T10:44:41.105+0000

  • Duration: 30 min 4 sec

blakerouse
blakerouse approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for picking this up!

@michalpristas michalpristas merged commit fe79a07 into elastic:master Jul 23, 2020
michalpristas added a commit to michalpristas/beats that referenced this pull request Jul 23, 2020
@michalpristas
[Ingest Manager] Fix failing unit tests on windows (elastic#20127)
e0870f7 
* remove skip

* close properly

* changelog

* space
michalpristas added a commit to michalpristas/beats that referenced this pull request Jul 23, 2020
@michalpristas
[Ingest Manager] Fix failing unit tests on windows (elastic#20127)
24741fe 
* remove skip

* close properly

* changelog

* space
This was referenced Jul 23, 2020
Merged
Merged
Merged
michalpristas added a commit that referenced this pull request Jul 23, 2020
@michalpristas
Cherry-pick #20127 to 7.9: Fix failing unit tests on windows (#20180)
02493ed 
* [Ingest Manager] Fix failing unit tests on windows (#20127)

* remove skip

* close properly

* changelog

* space

* prevent closing closed

* changelog
michalpristas added a commit that referenced this pull request Jul 23, 2020
@michalpristas
Cherry-pick #20127 to 7.x: Fix failing unit tests on windows (#20181)
85d07ae 
* [Ingest Manager] Fix failing unit tests on windows (#20127)

* remove skip

* close properly

* changelog

* space

* Changelog

* prevent closing closed

* changelog
v1v added a commit to v1v/beats that referenced this pull request Jul 27, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/ci-pipeli…
8175b5a 
…ne-2.0

* upstream/master: (41 commits)
  adding possibility to override content-type checks, it was breaking certain webhooks that is not able to set content-headers at all. Still defaults to application/json (elastic#20232)
  fix: use a fixed worker type for tests (elastic#20130)
  [Ingest Manager] Prepare packaging for endpoint and asc files (elastic#20186)
  [Packetbeat] HTTP: Improve support for 100-continue elastic#15830 (elastic#19349)
  Increase index.max_docvalue_fields_search to 200 (elastic#20218)
  [Ingest Manager] Prevent closing closed reader (elastic#20214)
  [Metricbeat] Use MySQL Host Parser in Query metricset (elastic#20191)
  Testing: Ignore timestamp from cylance/protect dataset (elastic#20211)
  [Filebeat] Ignore cylance.protect timestamps while testing (elastic#20207)
  [CI] remove codecov step (elastic#20102)
  [docs] Indicate that SYSTEM user is required on Windows to use Endpoint (elastic#20172)
  Remove f5/firepass rsa2elk fileset (elastic#20160)
  [Elastic Agent] Improve GRPC stop to be more relaxed. (elastic#20118)
  Fix fileset field prefixing (elastic#20170)
  Fix terminating pod autodiscover issue (elastic#20084)
  Call host parser only once when building light metricsets (elastic#20149)
  [CI] fix null string with contains (elastic#20182)
  [Ingest Manager] Fix failing unit tests on windows (elastic#20127)
  [Filebeat] Update crowdstrike module (elastic#20138)
  [docs] Add x-pack role to relevant metricsets (elastic#20167)
  ...
v1v added a commit to v1v/beats that referenced this pull request Jul 29, 2020
@v1v
Merge remote-tracking branch 'upstream/7.9' into backport/7.9/pr-19960
59a6124 
* upstream/7.9: (32 commits)
  feat(ci): support storing artifacts for PRs in separate dirs (elastic#20282) (elastic#20301)
  Cisco ASA: Fix message 106100 (elastic#20245) (elastic#20277)
  [CI] Change upstream reference (elastic#20296) (elastic#20297)
  [docs] Fix Windows download link for agent (elastic#20258) (elastic#20290)
  Cherry-pick to 7.9: [docs] Rename release highlights to what's new (elastic#20255) (elastic#20285)
  Elastic agent on k8s (elastic#19727) (elastic#20262)
  [Filebeat Module] Defender ATP - Adding dashboard (elastic#20058) (elastic#20093)
  fix: use a fixed worker type for tests (elastic#20130) (elastic#20247)
  [Elastic Agent] Fix Windows powershell install service script (elastic#20203) (elastic#20252)
  [Ingest Manager] Fixed unzip on older windows  (elastic#20088) (elastic#20109)
  adding possibility to override content-type checks, it was breaking certain webhooks that is not able to set content-headers at all. Still defaults to application/json (elastic#20232) (elastic#20237)
  [Filebeat][Gsuite] Make GSuite docs more clear (elastic#19981) (elastic#20067)
  Increase index.max_docvalue_fields_search to 200 (elastic#20218) (elastic#20221)
  Call host parser only once when building light metricsets (elastic#20149) (elastic#20190)
  [Metricbeat] Use MySQL Host Parser in Query metricset (elastic#20191) (elastic#20212)
  [Filebeat] Ignore cylance.protect timestamps while testing (elastic#20207) (elastic#20217)
  [libbeat] Fix write error in ensureWriter.Write (elastic#20112) (elastic#20145)
  Cherry-pick elastic#20127 to 7.9: Fix failing unit tests on windows  (elastic#20180)
  Remove f5/firepass rsa2elk fileset (elastic#20160) (elastic#20206)
  Cherry-pick elastic#20138 to 7.9: [Filebeat] Update crowdstrike module (elastic#20177)
  ...
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@michalpristas @melchiormoulin
[Ingest Manager] Fix failing unit tests on windows (elastic#20127)
3392581 
* remove skip

* close properly

* changelog

* space
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@michalpristas
Cherry-pick elastic#20127 to 7.9: Fix failing unit tests on windows (e…
46df8af 
…lastic#20180)

* [Ingest Manager] Fix failing unit tests on windows (elastic#20127)

* remove skip

* close properly

* changelog

* space

* prevent closing closed

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@michalpristas michalpristas

Labels
bug Ingest Management:beta1 Group issues for ingest management beta1 needs_backport PR is waiting to be backported to other branches. review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Agent] Failing unit test TestActionStore on Windows
3 participants
@michalpristas @elasticmachine @blakerouse