Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #20058 to 7.x: [Filebeat Module] Defender ATP - Adding dashboard #20092

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jul 21, 2020

Cherry-pick of PR #20058 to 7.x branch. Original message:

What does this PR do?

This PR adds a dashboard to the Microsoft Defender ATP module and updates the documentation with some styling fixes.

Why is it important?

Adds missing components to the documentation and adds some planned fixes to the docs to separate DHCP and the Defender ATP fileset

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 21, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 21, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-07-28T09:55:05.729+0000

  • Duration: 57 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 4265
Skipped 685
Total 4950

@P1llus
Copy link
Member

P1llus commented Jul 21, 2020

jenkins run tests

@marc-gr marc-gr force-pushed the backport_20058_7.x branch 2 times, most recently from adc5e23 to 7b0d249 Compare July 23, 2020 07:30
* adding dashboard to ATP, work in progress

* adding dashboard to ATP, removing a unused file, and fixing styling issues in the doc

* added description to dashboard and visualizations

(cherry picked from commit c306d45)
@marc-gr marc-gr force-pushed the backport_20058_7.x branch from 7b0d249 to eef760d Compare July 28, 2020 06:53
@marc-gr
Copy link
Contributor Author

marc-gr commented Jul 28, 2020

jenkins run tests

@marc-gr marc-gr merged commit f503865 into elastic:7.x Jul 28, 2020
@marc-gr marc-gr deleted the backport_20058_7.x branch July 28, 2020 10:55
@zube zube bot removed the [zube]: Done label Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants