Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix starttime of metricsets on dataset endpoint for metricbeat #19975

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

vjsamuel
Copy link
Contributor

Bug

What does this PR do?

Starttime of all metricsets on the /dataset endpoint is always "0001-01-01T00:00:00.000Z". This PR fixes that.

Why is it important?

Helps better debugging.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 16, 2020
@vjsamuel vjsamuel force-pushed the fix_dataset_starttime branch from f5421f7 to cdf80f1 Compare July 16, 2020 06:49
@andresrc andresrc added the Team:Integrations Label for the Integrations team label Jul 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 16, 2020
@vjsamuel vjsamuel force-pushed the fix_dataset_starttime branch from cdf80f1 to 978ce7e Compare July 17, 2020 23:26
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 17, 2020

💔 Tests Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [urso commented: jenkins run the tests please]

  • Start Time: 2020-07-21T18:31:13.682+0000

  • Duration: 75 min 50 sec

Test stats 🧪

Test Results
Failed 1
Passed 4154
Skipped 915
Total 5070

Test errors

Expand to view the tests failures

  • Name: Build and Test / Auditbeat oss Windows / TestActions – file_integrity

    • Age: 1
    • Duration: 0.07
    • Error Details: Failed

Steps errors

Expand to view the steps failures

  • Name: Mage build unitTest
    • Description: mage build unitTest

    • Duration: 3 min 12 sec

    • Start Time: 2020-07-21T19:00:11.391+0000

    • log

Log output

Expand to view the last 100 lines of log output

[2020-07-21T19:43:31.657Z] + FILE=libbeat/build/coverage/full.cov
[2020-07-21T19:43:31.657Z] + '[' -f libbeat/build/coverage/full.cov ']'
[2020-07-21T19:43:31.657Z] + for i in '"$@"'
[2020-07-21T19:43:31.657Z] + FILE=metricbeat/build/coverage/full.cov
[2020-07-21T19:43:31.657Z] + '[' -f metricbeat/build/coverage/full.cov ']'
[2020-07-21T19:43:31.657Z] + for i in '"$@"'
[2020-07-21T19:43:31.657Z] + FILE=packetbeat/build/coverage/full.cov
[2020-07-21T19:43:31.657Z] + '[' -f packetbeat/build/coverage/full.cov ']'
[2020-07-21T19:43:31.657Z] + for i in '"$@"'
[2020-07-21T19:43:31.657Z] + FILE=winlogbeat/build/coverage/full.cov
[2020-07-21T19:43:31.657Z] + '[' -f winlogbeat/build/coverage/full.cov ']'
[2020-07-21T19:43:32.896Z] Post stage
[2020-07-21T19:43:32.905Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats
[2020-07-21T19:43:33.683Z] Starting "default"...
[2020-07-21T19:43:33.684Z] Machine "default" is already running.
[2020-07-21T19:45:14.677Z] Error checking TLS connection: ssh command error:
[2020-07-21T19:45:14.677Z] command : ip addr show
[2020-07-21T19:45:14.677Z] err     : exit status 255
[2020-07-21T19:45:14.677Z] output  : 
[2020-07-21T19:45:14.677Z] Client: Docker Engine - Community
[2020-07-21T19:45:14.677Z]  Version:           19.03.1
[2020-07-21T19:45:14.677Z]  API version:       1.40
[2020-07-21T19:45:14.677Z]  Go version:        go1.12.5
[2020-07-21T19:45:14.677Z]  Git commit:        74b1e89
[2020-07-21T19:45:14.677Z]  Built:             Thu Jul 25 21:18:17 2019
[2020-07-21T19:45:14.677Z]  OS/Arch:           darwin/amd64
[2020-07-21T19:45:14.677Z]  Experimental:      false
[2020-07-21T19:45:14.677Z] Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
[2020-07-21T19:45:14.677Z] It requires Docker daemon to be installed and running
[2020-07-21T19:45:38.276Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats
[2020-07-21T19:45:38.585Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-07-21T19:45:38.596Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Lint
[2020-07-21T19:45:38.681Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Auditbeat-oss-Mac-OS-X
[2020-07-21T19:45:38.761Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Auditbeat-crosscompile
[2020-07-21T19:45:38.836Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Generators-Metricbeat-Linux
[2020-07-21T19:45:38.913Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Metricbeat-Mac-OS-X
[2020-07-21T19:45:39.002Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Metricbeat-x-pack-Mac-OS-X
[2020-07-21T19:45:39.083Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Metricbeat-OSS-Unit-tests
[2020-07-21T19:45:39.163Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Auditbeat-x-pack-Mac-OS-X
[2020-07-21T19:45:39.246Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Auditbeat-oss-Windows
[2020-07-21T19:45:39.323Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Auditbeat-x-pack
[2020-07-21T19:45:39.406Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Auditbeat-x-pack-Windows
[2020-07-21T19:45:39.490Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Auditbeat-oss-Linux
[2020-07-21T19:45:39.576Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Metricbeat-crosscompile
[2020-07-21T19:45:39.670Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Metricbeat-x-pack-Windows
[2020-07-21T19:45:39.758Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Metricbeat-Windows
[2020-07-21T19:45:39.840Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Generators-Beat-Linux
[2020-07-21T19:45:39.924Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Metricbeat-OSS-Go-Integration-tests
[2020-07-21T19:45:40.012Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Generators-Metricbeat-Mac-OS-X
[2020-07-21T19:45:40.114Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Metricbeat-OSS-Python-Integration-tests
[2020-07-21T19:45:40.204Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Metricbeat-x-pack
[2020-07-21T19:45:40.293Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Generators-Beat-Mac-OS-X
[2020-07-21T19:45:40.654Z] + cat
[2020-07-21T19:45:40.654Z] + /usr/local/bin/runbld ./runbld-script
[2020-07-21T19:45:40.654Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-07-21T19:45:47.241Z] runbld>>> runbld started
[2020-07-21T19:45:47.241Z] runbld>>> 1.6.12/f45d832f2ba0aa2722ab4ec1fda8ad140f027f8b
[2020-07-21T19:45:49.158Z] runbld>>> The following profiles matched the job 'Beats/beats/PR-19975' in order of occurrence in the config (last value wins).
[2020-07-21T19:45:50.542Z] runbld>>> Debug logging enabled.
[2020-07-21T19:45:50.542Z] runbld>>> Storing result
[2020-07-21T19:45:50.848Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-07-21T19:45:50.848Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200721194550-8F155421
[2020-07-21T19:45:50.848Z] runbld>>> Adding system facts.
[2020-07-21T19:45:51.790Z] runbld>>> Adding vcs info for the latest commit:  02ab143e26b5ac3235af44bad4069da957848969
[2020-07-21T19:45:51.790Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-07-21T19:45:51.790Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-07-21T19:45:51.790Z] Processing JUnit reports with runbld...
[2020-07-21T19:45:51.790Z] + echo 'Processing JUnit reports with runbld...'
[2020-07-21T19:45:52.360Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-07-21T19:45:52.360Z] runbld>>> DURATION: 24ms
[2020-07-21T19:45:52.360Z] runbld>>> STDOUT: 40 bytes
[2020-07-21T19:45:52.360Z] runbld>>> STDERR: 49 bytes
[2020-07-21T19:45:52.360Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-07-21T19:45:52.360Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats
[2020-07-21T19:45:53.303Z] runbld>>> Storing build metadata: 
[2020-07-21T19:45:53.303Z] runbld>>> Adding test report.
[2020-07-21T19:45:53.303Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats
[2020-07-21T19:45:54.244Z] runbld>>> Found 88 test output files
[2020-07-21T19:45:54.506Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-istio.xml
[2020-07-21T19:45:54.506Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-openmetrics.xml
[2020-07-21T19:45:54.766Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-tomcat.xml
[2020-07-21T19:45:54.766Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-activemq.xml
[2020-07-21T19:45:54.766Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-iis.xml
[2020-07-21T19:45:54.766Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Metricbeat-OSS-Go-Integration-tests/metricbeat/build/TEST-go-integration-graphite.xml
[2020-07-21T19:45:54.766Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-19975/src/github.com/elastic/beats/Metricbeat-OSS-Go-Integration-tests/metricbeat/build/TEST-go-integration-windows.xml
[2020-07-21T19:45:55.710Z] runbld>>> Test output logs contained: Errors: 0 Failures: 1 Tests: 5070 Skipped: 697
[2020-07-21T19:45:55.710Z] runbld>>> Storing result
[2020-07-21T19:45:55.710Z] runbld>>> FAILURES: 1
[2020-07-21T19:45:55.969Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-07-21T19:45:55.969Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200721194550-8F155421
[2020-07-21T19:45:56.229Z] runbld>>> Email notification disabled by environment variable.
[2020-07-21T19:45:56.229Z] runbld>>> Slack notification disabled by environment variable.
[2020-07-21T19:46:02.557Z] Running on worker-395930 in /var/lib/jenkins/workspace/Beats_beats_PR-19975
[2020-07-21T19:46:02.930Z] [INFO] getVaultSecret: Getting secrets
[2020-07-21T19:46:03.004Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-07-21T19:46:05.088Z] + chmod 755 generate-build-data.sh
[2020-07-21T19:46:05.088Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19975/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19975/runs/4 FAILURE 4490015
[2020-07-21T19:46:05.088Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19975/runs/4/steps/?limit=10000 -o steps-info.json
[2020-07-21T19:46:06.536Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19975/runs/4/tests/?status=FAILED -o tests-errors.json
[2020-07-21T19:46:07.988Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-19975/runs/4/log/ -o pipeline-log.txt

@urso urso self-assigned this Jul 21, 2020
@urso
Copy link

urso commented Jul 21, 2020

jenkins run the tests please

@urso urso merged commit 88cda01 into elastic:master Jul 22, 2020
@urso urso added the v7.10.0 label Jul 22, 2020
urso pushed a commit to urso/beats that referenced this pull request Jul 22, 2020
urso pushed a commit that referenced this pull request Jul 23, 2020
…point for metricbeat (#20147)

(cherry picked from commit 88cda01)

Co-authored-by: Vijay Samuel <[email protected]>
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@zube zube bot removed the [zube]: Done label Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Integrations Label for the Integrations team v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants