Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GOFLAGS=-mod=vendor from integration tests #19846

Conversation

andrewkroh
Copy link
Member

What does this PR do?

There is no more vendor folder so remove this flag when running integration tests. While running
tests we were seeing this:

run 'go mod vendor' to sync, or use -mod=mod or -mod=readonly to ignore the vendor directory
go: inconsistent vendoring in /go/src/github.com/elastic/beats:

Why is it important?

Fixes test failures.

Logs

There is no more vendor folder so remove this flag when running integration tests. While running
tests we were seeing this:

    run 'go mod vendor' to sync, or use -mod=mod or -mod=readonly to ignore the vendor directory
    go: inconsistent vendoring in /go/src/github.com/elastic/beats:
@andrewkroh andrewkroh requested a review from kvch July 13, 2020 15:21
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 13, 2020
@botelastic
Copy link

botelastic bot commented Jul 13, 2020

This pull request doesn't have a Team:<team> label.

@andrewkroh
Copy link
Member Author

Fixed by #19839

@andrewkroh andrewkroh closed this Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_team Indicates that the issue/PR needs a Team:* label review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant