Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #19660 to 7.x: [MetricBeat] support wildcard * dimension value in AWS CloudWatch module #19714

Merged
merged 4 commits into from
Jul 8, 2020
Merged

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jul 7, 2020

Cherry-pick of PR #19660 to 7.x branch. Original message:

  • Enhancement

What does this PR do?

  • support wildcard * dimension value in AWS CloudWatch metrics config
  • update document with example config

Why is it important?

Now we must set explicit dimension value to filter out CloudWatch metrics. It will be flexible if we can support wildcard * in value param.

current config example:

- module: aws
  period: 300s
  metricsets:
    - cloudwatch
  metrics:
    - namespace: AWS/ApplicationELB
      statistic: ['Maximum']
      name: ['UnHealthyHostCount']
      dimensions:
        - name: LoadBalancer
          value: "lb id"
        - name: TargetGroup
          value: "tg id"

with the enhancement:

- module: aws
  period: 300s
  metricsets:
    - cloudwatch
  metrics:
    - namespace: AWS/ApplicationELB
      statistic: ['Maximum']
      name: ['UnHealthyHostCount']
      dimensions:
        - name: LoadBalancer
          value: "*"
        - name: TargetGroup
          value: "*"

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

…odule (#19660)

* dimension value could be wildcard `*`, it is more flexible

(cherry picked from commit ee4882c)
@kaiyan-sheng kaiyan-sheng added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Jul 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 7, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Jul 7, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 7, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19714 updated]

  • Start Time: 2020-07-08T16:11:41.628+0000

  • Duration: 42 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 729
Skipped 72
Total 801

@kaiyan-sheng
Copy link
Contributor Author

jenkins, run the tests please

@kaiyan-sheng kaiyan-sheng merged commit f09b7ad into elastic:7.x Jul 8, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_19660_7.x branch July 8, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team [zube]: Done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants