-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sophosxg-module initial release #19591
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
💚 CLA has been signed |
Pinging @elastic/siem (Team:SIEM) |
This is a PR that was planned with @StefanSa over email, we will try to collaborate and apply any changes needed before we can start a review. Thanks a lot for the contribution! |
cla/check |
jenkins, test this |
Jenkins, run tests please |
1 similar comment
Jenkins, run tests please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. a few spelling mistakes to fix and some data type suggestions.
x-pack/filebeat/module/sophosxg/firewall/test/sandbox.log-expected.json
Outdated
Show resolved
Hide resolved
x-pack/filebeat/module/sophosxg/firewall/test/sandbox.log-expected.json
Outdated
Show resolved
Hide resolved
x-pack/filebeat/module/sophosxg/firewall/test/waf.log-expected.json
Outdated
Show resolved
Hide resolved
@StefanSa Thank you very much for your work. It would be great have this module available soon. I am working on a similar project for one of our customers. The difference is that it needs to support Sophos UTM, especially the SG5xx product family. Do you know if these platforms are compatible in terms of logs or if two different modules are possible? If they are different, would it be possible to merge them together into one module or would it require two separate modules? |
@Bernhard-Fluehmann |
Pinging @elastic/ingest-management (Team:Ingest Management) |
@StefanSa It seems that the structure of the logs is similar but unfortunately the log header and field names are different. Please have a look at our repo . Under x-pack you find the sophosutm module which contains the current state of our work. |
@Bernhard-Fluehmann I think in the long run, most likely for a separate release, we would need to think about renaming the module to sophos, and have the filesets be called sophosxg and sophosutm. I might be able to convert the sophosxg one to follow that convention |
@P1llus This is great, thanks. It seems that the official namings are is xg-firewall and sg-utm, while utm is the legacy platform and sg firewalls can be migrated to xg os. BTW, I have some troubles building beats on my macbook. Since I have updated go and xcode command line tools make release works. But now the testsuite fails with the following error: |
@Bernhard-Fluehmann Yeah the pointer here will be to have it similar to the other modules, where the module name is the vendor and the fileset is the product. That way we can keep the separation between XG, UTM and any other module later on. I think when this PR is merged, you can pull the latest update from our master, add your new fileset if you want, to the sophos module (il make sure to rename the folders before merging), and create a PR adding the fileset. In terms of building, the way its built has changed a bit maybe, depending on what you are trying to do here. If you are in the ./beats/x-pack/filebeat directory, make sure to delete the build folder and that you have the correct go version. I would recommend checking out what can be wrong, by ensuring that you have the correct go version and grab a clone of our repo and try to run it there. If you are merging with master from time to time there might also be that you happen to be on a broken commit, should try to rebase with the newest master as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But can you undo the go.sum changes.
…so generated new nosetest expected output
jenkins run tests |
jenkins, test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jenkins, test this |
…15 events but got 18
What does this PR do? This PR Introduces the SophosXG filebeat module. Focusing currently on SophosXG Firewall, but should include other Sophos products as separate PR's later on. Why is it important? Adding more supported products to the filebeat portfolio. Co-authored-by: StefanSa <[email protected]> Co-authored-by: P1llus <[email protected]> (cherry picked from commit 4f36c92)
What does this PR do? This PR Introduces the SophosXG filebeat module. Focusing currently on SophosXG Firewall, but should include other Sophos products as separate PR's later on. Why is it important? Adding more supported products to the filebeat portfolio. (cherry picked from commit 4f36c92) Co-authored-by: StefanSa <[email protected]> Co-authored-by: P1llus <[email protected]>
What does this PR do? This PR Introduces the SophosXG filebeat module. Focusing currently on SophosXG Firewall, but should include other Sophos products as separate PR's later on. Why is it important? Adding more supported products to the filebeat portfolio. Co-authored-by: StefanSa <[email protected]> Co-authored-by: P1llus <[email protected]>
What does this PR do?
This PR Introduces the SophosXG filebeat module. Focusing currently on SophosXG Firewall, but should include other Sophos products as separate PR's later on.
Why is it important?
Adding more supported products to the filebeat portfolio.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
INTEGRATION_TESTS=1 BEAT_STRICT_PERMS=false TESTING_FILEBEAT_MODULES=sophosxg nosetests -v -s tests/system/test_xpack_modules.py