[Elastic Agent] Properly stop subprocess when receiving SIGTERM #19567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly when Elastic Agent is signalled to stop.
botelastic
bot
added
the
needs_team
botelastic
bot
removed
the
needs_team
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
💔 Build Failed
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
ph
approved these changes
Jul 6, 2020
Merged
3 tasks
blakerouse
added a commit
to blakerouse/beats
that referenced
this pull request
Jul 6, 2020
…tic#19567) * Implement proper shutdown so spawned subprocesses are stopped correctly when Elastic Agent is signalled to stop. * Swap shutdown order for fleet mode. * Reorder stop in local_mode. Add to changelog. (cherry picked from commit a820842)
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
…tic#19567) * Implement proper shutdown so spawned subprocesses are stopped correctly when Elastic Agent is signalled to stop. * Swap shutdown order for fleet mode. * Reorder stop in local_mode. Add to changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue where if Elastic Agent is stopped the spawned subprocesses are not stopped. This ensures that on
SIGTERMto Elastic Agent that it properly shutdowns the subprocesses, by sending theExpectedState_Stoppingover GRPC and waiting for the process to stop (kill it after 30 seconds, if it doesn't stop).On Linux in the case that Elastic Agent is
kill -9all its spawned subprocesses will also bekill -9, without having to worry that any children processes are still handing around. Something that Windows or Mac does not support.Why is it important?
So subprocess are not orphaned when Elastic Agent is stopped or killed.
Checklist
[] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Logs