Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #19503 to 7.x: [Elastic Agent] Fix artifact downloading to allow endpoint-security to be downloaded #19513

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

blakerouse
Copy link
Contributor

Cherry-pick of PR #19503 to 7.x branch. Original message:

What does this PR do?

Fixes the downloading of artifacts to allow the URI to be different depending on the artifacts that need to be downloaded. Adds a artifact key to the spec file, that allows the path of the artifacts download URI to be constructed so the download can come from different repositories, not just the beats repo.

Why is it important?

So Elastic Agent can download the builds for Endpoint Security.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

…o be downloaded (elastic#19503)

* Fix downloading so its not hard coded to beats repo name.

* Add artifact to spec file, use artifact for download.

* Fix tar installer.

* Fix downloading.

* Fix tests.

* Add changelog.

* Revert some un-needed changes.

(cherry picked from commit 25e223f)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 30, 2020
@blakerouse blakerouse self-assigned this Jun 30, 2020
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport looks good

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19513 opened]

  • Start Time: 2020-06-30T13:01:11.224+0000

  • Duration: 35 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 539
Skipped 127
Total 666

@blakerouse blakerouse merged commit 3350512 into elastic:7.x Jun 30, 2020
@blakerouse blakerouse deleted the backport_19503_7.x branch June 30, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants