fix: ignore target changes on scans #19510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuisathaverat
added
enhancement
ci
Team:Automation
botelastic
bot
added
needs_team
kuisathaverat
commented
Jun 30, 2020
| @@ -23,7 +23,7 @@ | |||
| credentials: f6c7695a-671e-4f4f-a331-acdce44ff9ba | |||
| build-strategies: | |||
| - tags: | |||
| ignore-tags-older-than: -1 | |||
| ignore-tags-older-than: 30 | |||
There was a problem hiding this comment.
Ignore tags older than 30 days
cachedout
approved these changes
Jun 30, 2020
v1v
reviewed
Jun 30, 2020
| @@ -36,7 +36,7 @@ | |||
| regex: '8\.\d+' | |||
| case-sensitive: true | |||
| - change-request: | |||
| ignore-target-only-changes: false | |||
| ignore-target-only-changes: true | |||
There was a problem hiding this comment.
neat! That's the one you mentioned :)
v1v
approved these changes
Jun 30, 2020
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
urso
approved these changes
Jun 30, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 2, 2020
…ne-beats * upstream/master: (105 commits) ci: enable packaging job (elastic#19536) ci: disable upstream trigger on PRs for the packaging job (elastic#19490) Implement memlog on-disk handling (elastic#19408) fix go.mod for PR elastic#19423 (elastic#19521) [MetricBeat] add param `aws_partition` to support aws-cn, aws-us-gov regions (elastic#19423) Input v2 stateless manager (elastic#19406) Input v2 compatibility layer (elastic#19401) [Elastic Agent] Fix artifact downloading to allow endpoint-security to be downloaded (elastic#19503) fix: ignore target changes on scans (elastic#19510) Add more helpers to pipeline/testing package (elastic#19405) Report dependencies in CSV format (elastic#19506) [Filebeat] Fix reference leak in TCP and Unix socket inputs (elastic#19459) Cursor input skeleton (elastic#19378) Add changelog. (elastic#19495) [DOC] Typo in Kerberos (elastic#19265) Remove accidentally commited unused NOTICE template (elastic#19485) [Elastic Agent] Support the install, control, and uninstall of Endpoint (elastic#19248) [Filebeat][httpjson] Add split_events_by config setting (elastic#19246) ci: disabling packaging job until we fix it (elastic#19481) Fix golang.org/x/tools to release1.13 (elastic#19478) ...
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It changes the behavior to build PRs when Jenkins makes a scan, instead of trigger all PRs if the target branch has changed, the builds are only triggered if there's changes in the PR and we did not test them.
Why is it important?
With the amount of PRs and branches that this repo has built all PRs on changes in the master is not an option, we would use all the resources we have and we block the real builds we need to make.
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.