[Filebeat][httpjson] Add date_cursor to httpjson input #19483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
marc-gr
force-pushed
the
filebeat_httpjson_add_date_cursor
branch
from
300e894 to
e4a5c6a
Compare
marc-gr
added
review
and removed
in progress
P1llus
reviewed
Jun 30, 2020
|
Tested this with the ATP module and seems to be working just fine |
marc-gr
force-pushed
the
filebeat_httpjson_add_date_cursor
branch
from
9fc80d0 to
d4b655a
Compare
|
Added |
andrewkroh
approved these changes
Jun 30, 2020
marc-gr
force-pushed
the
filebeat_httpjson_add_date_cursor
branch
from
d4b655a to
09d408a
Compare
marc-gr
force-pushed
the
filebeat_httpjson_add_date_cursor
branch
from
3c9b5e0 to
d04d3fe
Compare
marc-gr
added
the
needs_backport
marc-gr
added a commit
to marc-gr/beats
that referenced
this pull request
Jul 14, 2020
* Add date_cursor to httpjson input * Add changelog entry * Fix tests * Default to UTC date * Add date_cursor validations and better error message * Run fmt update (cherry picked from commit 775f134)
4 tasks
marc-gr
removed
the
needs_backport
marc-gr
added a commit
that referenced
this pull request
Jul 14, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
* Add date_cursor to httpjson input * Add changelog entry * Fix tests * Default to UTC date * Add date_cursor validations and better error message * Run fmt update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the ability to set a
date_cursorinhttpjsoninput. This can be used to make date based requests to the endpoint.Why is it important?
To prevent requesting big amounts of events, or repeated events from APIs.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Not sure if adding it to docs or not, since this is meant for very specific use cases for now.