Dissect: Support trimming captured values and other configuration options #19464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
adriansr
force-pushed
the
dissect_options
branch
from
fcd9f2e to
b340e99
Compare
adriansr
added
review
needs_backport
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
--------------------- >> end captured stdout << ---------------------- Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
botelastic
bot
removed
the
needs_team
|
Pinging @elastic/siem (Team:SIEM) |
andrewkroh
approved these changes
Jun 28, 2020
| - `right`: values are trimmed on the right (trailing). | ||
| - `all`: values are trimmed for leading and trailing. | ||
|
|
||
| `trim_chars`:: (Optional) Set of characters to trim from values, when trimming |
There was a problem hiding this comment.
I was wondering if this value was a list of characters or a string or characters. Either stating the data type or including an example would help.
adriansr
force-pushed
the
dissect_options
branch
from
b340e99 to
e15068a
Compare
ph
approved these changes
Jun 29, 2020
|
cc @sayden |
sayden
approved these changes
Jun 30, 2020
|
rebased hoping to pass CI |
|
Jenkins, run tests please |
1 similar comment
|
Jenkins, run tests please |
|
Test failures unrelated |
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Jul 6, 2020
…ions (elastic#19464) This adds 4 new configuration parameters for the dissect processor: - ignore_failure, so that it doesn't return an error when the tokenizer doesn't match the input. This is useful for chaining multiple processors together. - overwrite_keys, so that existing keys are overwritten if they already exist. - trim_values, to enable trimming blank space (left,(leading) right(trailing) or all) in captured values. - trim_chars is the set of characters that are trimmed by the above option (default is the ascii space character). The default values for these new flags have been chosen so that the default behavior of the processor is unchanged. (cherry picked from commit a57e390)
6 tasks
adriansr
added
v7.9.0
and removed
needs_backport
adriansr
added a commit
that referenced
this pull request
Jul 13, 2020
…ions (#19464) (#19685) This adds 4 new configuration parameters for the dissect processor: - ignore_failure, so that it doesn't return an error when the tokenizer doesn't match the input. This is useful for chaining multiple processors together. - overwrite_keys, so that existing keys are overwritten if they already exist. - trim_values, to enable trimming blank space (left,(leading) right(trailing) or all) in captured values. - trim_chars is the set of characters that are trimmed by the above option (default is the ascii space character). The default values for these new flags have been chosen so that the default behavior of the processor is unchanged. (cherry picked from commit a57e390)
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
…ions (elastic#19464) This adds 4 new configuration parameters for the dissect processor: - ignore_failure, so that it doesn't return an error when the tokenizer doesn't match the input. This is useful for chaining multiple processors together. - overwrite_keys, so that existing keys are overwritten if they already exist. - trim_values, to enable trimming blank space (left,(leading) right(trailing) or all) in captured values. - trim_chars is the set of characters that are trimmed by the above option (default is the ascii space character). The default values for these new flags have been chosen so that the default behavior of the processor is unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds 4 new configuration parameters for the dissect processor:
ignore_failure, so that it doesn't return an error when the tokenizer doesn't match the input. This is useful for chaining multiple processors together.overwrite_keys, so that existing keys are overwritten if they already exist.trim_values, to enable trimming blank space (left,(leading)right(trailing) orall) in captured values.trim_charsis the set of characters that are trimmed by the above option (default is the ascii space character).The default values for these new flags have been chosen so that the default behavior of the processor is unchanged.
Why is it important?
These new flags are necessary to make dissect more useful and easy to use when used in chains of processors, for example a cascade of processors when only one of them is expected to match the input.
Checklist
I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.