Cherry-pick #19055 to 6.8: [Metricbeat] Update Couchbase module to 6.5 version #19462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c7f9937) # Conflicts: # metricbeat/docs/fields.asciidoc # metricbeat/module/couchbase/_meta/Dockerfile # metricbeat/module/couchbase/_meta/docs.asciidoc # metricbeat/module/couchbase/docker-compose.yml # metricbeat/module/couchbase/fields.go # metricbeat/module/couchbase/test_couchbase.py
sayden
added
backport
[zube]: In Review
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
added
needs_team
|
jenkins, test this again please |
|
Failures in travis and jenkins are not new, tests pass locally. |
jsoriano
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #19055 to 6.8 branch. Original message:
What does this PR do?
Changes the number format of some fields that seems to be returned in floating point while we expect them like integers.
It seems that some of the values returned by Couchbase are in floating point numbers. In fact, all the data is returned in JSON format so every single number might be a floating point number.
Checklist
[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Just execute the module normally. Unfortunately, the bug can't be reproduce easily (or at all)
Related issues
Fixes: #18949
Fixes: #18595