[Filebeat] Explicitly set ECS version in Filebeat modules. #19198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leehinman
added
enhancement
Filebeat
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
needs_team
- Add test to check if ecs.version is set - add_fields to azure/activitylogs - add_fields to azure/auditlogs - add_fields to azure/signinlogs - add_fields to checkpoint/firewall - add_fields to crowdstrike/falcon - add_fields to fortinet/firewall - add_fields to traefik/access Relates elastic#17688
leehinman
force-pushed
the
explicit_ecs_version
branch
from
fd48385 to
7fb13c5
Compare
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
andrewkroh
approved these changes
Jun 15, 2020
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Jun 16, 2020
…9198) * Explicitly set ECS version in Filebeat modules. - Add test to check if ecs.version is set - add_fields to azure/activitylogs - add_fields to azure/auditlogs - add_fields to azure/signinlogs - add_fields to checkpoint/firewall - add_fields to crowdstrike/falcon - add_fields to fortinet/firewall - add_fields to traefik/access Relates elastic#17688 (cherry picked from commit 81b0c3a)
5 tasks
leehinman
added
v7.9.0
and removed
needs_backport
leehinman
added a commit
that referenced
this pull request
Jun 25, 2020
…19223) * Explicitly set ECS version in Filebeat modules. - Add test to check if ecs.version is set - add_fields to azure/activitylogs - add_fields to azure/auditlogs - add_fields to azure/signinlogs - add_fields to checkpoint/firewall - add_fields to crowdstrike/falcon - add_fields to fortinet/firewall - add_fields to traefik/access Relates #17688 (cherry picked from commit 81b0c3a)
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
…9198) * Explicitly set ECS version in Filebeat modules. - Add test to check if ecs.version is set - add_fields to azure/activitylogs - add_fields to azure/auditlogs - add_fields to azure/signinlogs - add_fields to checkpoint/firewall - add_fields to crowdstrike/falcon - add_fields to fortinet/firewall - add_fields to traefik/access Relates elastic#17688
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses the add_fields processor to explicitly set the ecs version the
fileset was written to. The following filesets were updated, all
other filesets already were doing this.
Also added a test to pythonIntegTest that will check to make sure the
ecs version is set.
Why is it important?
When upgrading filesets we need to know what version of ECS it was
originally written against, that makes it much easier to do the
upgrade. Also when writing rules and searches if you know what
version of ecs the data is, you know what fields are available to you
and what ones aren't.
Checklist
- [ ] I have made corresponding changes to the documentationCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Related issues