Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #19131 to 7.8: [filebeat][netflow] Support up to 7 bytepad for Netflow IPFIX template #19190

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jun 15, 2020

Cherry-pick of PR #19131 to 7.8 branch. Original message:

What does this PR do?

Fixes netflow v9 decoder to support up to 7 bytes of padding for IPFIX templates.

Why is it important?

Previously was failing to process packets with more than 3 bytes of padding.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Fixes #18098

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 15, 2020
@botelastic
Copy link

botelastic bot commented Jun 15, 2020

This pull request doesn't have a Team:<team> label.

@marc-gr marc-gr requested a review from a team June 15, 2020 10:13
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19190 opened]

  • Start Time: 2020-06-15T10:13:08.709+0000

  • Duration: 45 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 1686
Skipped 255
Total 1941

@marc-gr marc-gr merged commit 2535ca5 into elastic:7.8 Jun 15, 2020
@marc-gr marc-gr deleted the backport_19131_7.8 branch June 15, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants