Fix unused libbeat.config.module metrics #19168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
bug
review
libbeat
Team:Services
botelastic
bot
added
needs_team
These metrics existed in the code but were unused and hence always 0.
"libbeat":{"config":{"module":{"running":0,"starts":0,"stops":0}
I updated the module reload code to increment and set the metrics when changes are applied.
andrewkroh
force-pushed
the
bugfix/libbeat/config-module-metrics
branch
from
fdb336e to
629b379
Compare
andrewkroh
added
the
needs_backport
|
Pinging @elastic/integrations-services (Team:Services) |
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Log outputExpand to view the last 100 lines of log output
|
urso
reviewed
Jun 15, 2020
| } | ||
|
|
||
| moduleRunning.Set(int64(len(r.runners))) |
There was a problem hiding this comment.
Let's add a comment here that the metric is not necessarily correct. The Reload method calls go runner.Stop and immediately removes the runner from the hashtable. But in fact (especially filebeat) the runner/input might still be active for an unknown amount of time (it's a common problem with reconfigured filebeat inputs erroring out on Start).
There was a problem hiding this comment.
Good point, I guess the original name wasn't necessary the best for this. I added some comments.
urso
approved these changes
Jun 16, 2020
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Jun 18, 2020
These metrics existed in the code but were unused and hence always 0.
"libbeat":{"config":{"module":{"running":0,"starts":0,"stops":0}
I updated the module reload code to increment and set the metrics when changes are applied.
(cherry picked from commit 5d7e83b)
6 tasks
andrewkroh
added
v7.9.0
and removed
needs_backport
andrewkroh
added a commit
that referenced
this pull request
Jun 18, 2020
These metrics existed in the code but were unused and hence always 0.
"libbeat":{"config":{"module":{"running":0,"starts":0,"stops":0}
I updated the module reload code to increment and set the metrics when changes are applied.
(cherry picked from commit 5d7e83b)
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
These metrics existed in the code but were unused and hence always 0.
"libbeat":{"config":{"module":{"running":0,"starts":0,"stops":0}
I updated the module reload code to increment and set the metrics when changes are applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These metrics existed in the code but were unused and hence always 0.
"libbeat":{"config":{"module":{"running":0,"starts":0,"stops":0}
I updated the module reload code to increment and set the metrics when changes are applied.
Why is it important?
If the metrics are exposed by
/statsthen they should work, otherwise they are misleading.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Logs
I tested the metrics using Auditbeat module reloading: