-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Fix Cisco ASA dissect pattern for 313008 & 313009 #19149
Conversation
Extra space after column causes 'Unable to find match for dissect pattern' error.
Pinging @elastic/siem (Team:SIEM) |
Hi @ajoliveira 🙂 Do you mind to add an example line on https://github.com/elastic/beats/blob/master/x-pack/filebeat/module/cisco/asa/test/asa-fix.log and re-run tests to commit the result of the "expected" file (same folder), please? 🙂 I've just checked their docs and it seems they have the same "typo" there: |
@sayden I was able to track down an example for the 313008 but not 313009, so added that one at least. I assumed the typo was the same for both when I compared your doc link to another I found - https://www.cisco.com/en/US/docs/security/asa/asa80/system/message/logmsgs.html#wp4771141 as well as link for Messages Listed by Severity Level in the doc you noted, you see it without extra space. I added the example line as requested for 313008. Let me know if okay to leave the other or need to revert it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…#19267) Extra space after column causes 'Unable to find match for dissect pattern' error. (cherry picked from commit 155013a) Co-authored-by: Angelo Oliveira <[email protected]>
…#19149) Extra space after column causes 'Unable to find match for dissect pattern' error.
…#19149) (elastic#19267) Extra space after column causes 'Unable to find match for dissect pattern' error. (cherry picked from commit c6eea91) Co-authored-by: Angelo Oliveira <[email protected]>
What does this PR do?
Corrects parsing errors for message IDs 313008 & 313009 that have space after comma that lead to 'Unable to find match for dissect pattern' error.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.