Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Fix Cisco ASA dissect pattern for 313008 & 313009 #19149

Merged
merged 6 commits into from
Jun 16, 2020

Conversation

ajoliveira
Copy link
Contributor

@ajoliveira ajoliveira commented Jun 12, 2020

What does this PR do?

Corrects parsing errors for message IDs 313008 & 313009 that have space after comma that lead to 'Unable to find match for dissect pattern' error.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Extra space after column causes 'Unable to find match for dissect pattern' error.
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 12, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 12, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 12, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user Adrian Serrano, Replayed #9]

  • Start Time: 2020-06-16T07:09:44.578+0000

  • Duration: 48 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 2346
Skipped 382
Total 2728

@sayden
Copy link
Contributor

sayden commented Jun 12, 2020

Hi @ajoliveira 🙂 Do you mind to add an example line on https://github.com/elastic/beats/blob/master/x-pack/filebeat/module/cisco/asa/test/asa-fix.log and re-run tests to commit the result of the "expected" file (same folder), please? 🙂

I've just checked their docs and it seems they have the same "typo" there:
https://www.cisco.com/c/en/us/td/docs/security/asa/syslog/b_syslog/syslogs3.html#con_4771141

@ajoliveira
Copy link
Contributor Author

@sayden I was able to track down an example for the 313008 but not 313009, so added that one at least. I assumed the typo was the same for both when I compared your doc link to another I found - https://www.cisco.com/en/US/docs/security/asa/asa80/system/message/logmsgs.html#wp4771141 as well as link for Messages Listed by Severity Level in the doc you noted, you see it without extra space.

I added the example line as requested for 313008. Let me know if okay to leave the other or need to revert it.

@adriansr adriansr added the needs_backport PR is waiting to be backported to other branches. label Jun 15, 2020
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adriansr adriansr merged commit 155013a into master Jun 16, 2020
@adriansr adriansr added v7.9.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jun 17, 2020
adriansr pushed a commit to adriansr/beats that referenced this pull request Jul 6, 2020
…#19149)

Extra space after column causes 'Unable to find match for dissect pattern' error.

(cherry picked from commit 155013a)
adriansr added a commit that referenced this pull request Jul 6, 2020
…#19267)

Extra space after column causes 'Unable to find match for dissect pattern' error.

(cherry picked from commit 155013a)

Co-authored-by: Angelo Oliveira <[email protected]>
adriansr pushed a commit to adriansr/beats that referenced this pull request Jul 12, 2020
…#19149)

Extra space after column causes 'Unable to find match for dissect pattern' error.

(cherry picked from commit 155013a)
adriansr added a commit that referenced this pull request Jul 13, 2020
…or 313008 & 313009 (#19235)

Extra space after column causes 'Unable to find match for dissect pattern' error.

(cherry picked from commit 155013a)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
…#19149)

Extra space after column causes 'Unable to find match for dissect pattern' error.
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…#19149) (elastic#19267)

Extra space after column causes 'Unable to find match for dissect pattern' error.

(cherry picked from commit c6eea91)

Co-authored-by: Angelo Oliveira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants