Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18537 to 7.x: [Filebeat] Improve ECS categorization field mappings in cisco module #18982

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented Jun 4, 2020

Cherry-pick of PR #18537 to 7.x branch. Original message:

What does this PR do?

Improves ECS categorization field mappings in cisco module

Specifically:

  • asa
    • explicitly set ECS version
    • event.kind
    • event.category
    • event.type
    • related.hash
    • related.ip
    • related.user
  • ftd
    • explicitly set ECS version
    • event.kind
    • event.category
    • event.type
    • related.hash
    • related.ip
    • related.user
  • ios
    • explicitly set ECS version
    • event.kind
    • event.category
    • event.type

Why is it important?

ECS categorization fields make the data more useful in the SIEM app and make cross correlation between data sources easier.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

TESTING_FILEBEAT_MODULES=cisco mage -v pythonIntegTest

Related issues

…lastic#18537)

* Improve ECS categorization field mappings in cisco module

- asa
  + explicitly set ECS version
  + event.kind
  + event.category
  + event.type
  + related.hash
  + related.ip
  + related.user
- ftd
  + explicitly set ECS version
  + event.kind
  + event.category
  + event.type
  + related.hash
  + related.ip
  + related.user
- ios
  + explicitly set ECS version
  + event.kind
  + event.category
  + event.type

Closes elastic#16028

Co-authored-by: Andrew Kroh <[email protected]>
(cherry picked from commit f1139f2)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 4, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18982 opened]

  • Start Time: 2020-06-04T18:39:31.839+0000

  • Duration: 47 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 1716
Skipped 255
Total 1971

@leehinman leehinman merged commit e633606 into elastic:7.x Jun 5, 2020
@leehinman leehinman deleted the backport_18537_7.x branch October 5, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants