Cherry-pick #18865 to 7.x: index_pattern
under visState.params cannot be empty ""
#18947
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #18865 to 7.x branch. Original message:
This PR is to add check to make sure
index_pattern
under visState.params not be empty""
. For example in metricbeat dashboard/visualization, when default index is notmetricbeat-*
in Kibana and index_pattern is set to""
, visualizations will take the default index pattern by default. If the default index pattern is notmetricbeat-*
, then these dashboards will fail and show no data.This PR is to not only fix the rest of the dashboards having this issue but also adding the check in
mage/check.go
.Related PR: #18698
Discuss Forum Link: https://discuss.elastic.co/t/metricbeats-dashboards-for-kubernetes-controller-manager/233402/4
This PR also improved the error message on which visualization failed the test: