Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat][http_endpoint] Removing enforcement of accept header #18768

Merged
merged 2 commits into from
May 27, 2020
Merged

[Filebeat][http_endpoint] Removing enforcement of accept header #18768

merged 2 commits into from
May 27, 2020

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented May 27, 2020 •
edited
Loading

For now it will break webhooks that cannot set accept headers, so removing it for now, might reintroduce it later if there is any usecases for it

What does this PR do?

Removing accept header validation of incoming http requests for the http_endpoint module

Why is it important?

Makes the module support more webhooks (like github)

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 27, 2020
@P1llus P1llus added the Team:Integrations Label for the Integrations team label May 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 27, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 27, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18768 updated]

  • Start Time: 2020-05-27T10:57:17.541+0000

  • Duration: 46 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 2210
Skipped 382
Total 2592

@kvch kvch added the needs_backport PR is waiting to be backported to other branches. label May 27, 2020
@kvch kvch merged commit 80130af into elastic:master May 27, 2020
@P1llus P1llus deleted the http_input_headerfix branch May 27, 2020 13:25
kvch pushed a commit to kvch/beats that referenced this pull request Jun 2, 2020
@P1llus @kvch
Removing enforcement of accept header in http_endpoint input (elastic…
e4e805b 
…#18768)

(cherry picked from commit 80130af)
@kvch kvch mentioned this pull request Jun 2, 2020
Merged
5 tasks
@kvch kvch added v7.9.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jun 2, 2020
kvch added a commit that referenced this pull request Jun 2, 2020
@kvch @P1llus
Removing enforcement of accept header in http_endpoint input (#18768) (…
1f44de3 
…#18895)

(cherry picked from commit 80130af)

Co-authored-by: Marius Iversen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvch kvch kvch approved these changes

Assignees
No one assigned
Labels
enhancement Filebeat Filebeat review Team:Integrations Label for the Integrations team v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@P1llus @elasticmachine @kvch