Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Avoid watching monitor logs #18723

Merged
merged 3 commits into from
May 26, 2020

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented May 25, 2020

What does this PR do?

This PR differentiates beat for its purpose (normal/monitoring) and avoids monitoring output of monitoring beats.
It does it checking special tags passed in descriptor if tag is present it redirect logs to {original_path}_monitor file/socket so it is not picked up by monitor

Why is it important?

to lower CPU consumption and avoid publishing monitoring logs about monitored logs

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 25, 2020
@michalpristas michalpristas changed the title do not monitor self [Ingest Manager] Avoid watching monitor logs May 25, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 25, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18723 event]

  • Start Time: 2020-05-25T14:45:35.303+0000

  • Duration: 30 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 505
Skipped 127
Total 632

Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, have to test it.

@michalpristas michalpristas merged commit dc7ba20 into elastic:master May 26, 2020
michalpristas added a commit to michalpristas/beats that referenced this pull request May 27, 2020
[Ingest Manager] Avoid watching monitor logs (elastic#18723)
michalpristas added a commit to michalpristas/beats that referenced this pull request May 27, 2020
[Ingest Manager] Avoid watching monitor logs (elastic#18723)
@michalpristas
Copy link
Contributor Author

this seems to be a blocker for enabling monitoring on windows.

michalpristas added a commit that referenced this pull request May 27, 2020
* [Ingest Manager] Avoid watching monitor logs (#18723)

[Ingest Manager] Avoid watching monitor logs (#18723)

* updated changelog
michalpristas added a commit that referenced this pull request May 27, 2020
Cherry-pick #18723 to 7.x: Avoid watching monitor logs  (#18761)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Ingest Management:alpha1 Group issues for ingest management alpha1 review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants