Report if index is hidden in index stats #18706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
ycombinator
force-pushed
the
mb-es-xp-index-mark-hidden
branch
from
f487f0c to
22de4c2
Compare
ycombinator
added
in progress
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
removed
the
needs_team
|
Pinging @elastic/stack-monitoring (Stack monitoring) |
ycombinator
force-pushed
the
mb-es-xp-index-mark-hidden
branch
from
22de4c2 to
c07c160
Compare
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
urso
reviewed
Jul 7, 2020
| Settings struct { | ||
| Index struct { | ||
| Hidden string `json:"hidden"` | ||
| } `json:"index"` |
There was a problem hiding this comment.
why not Hidden bool, or Index IndexSettings json:"index"?
There was a problem hiding this comment.
It had to do with the type of index.hidden in the Elasticsearch API's JSON response being a string, e.g. "true", instead of being a JSON boolean, e.g. true. Let me make a commit showing what I tried before this, implementing json.Unmarshaler, then we can decide which implementation we like better.
There was a problem hiding this comment.
Uff, I see. If we would use something like boolstr more often we might consider to provide a package/library with decoding primitives. But here as a standalone single use case within the package I think I prefer to decode into string first. A hybrid solution could be Index struct { Hidden boolstr json:"index" }, but keep IndexSetting{ Hidden bool }. Then you might be able to cast from Index into IndexSetting directly. Using boolstr we see decoding errors directly returned from the JSON decoder if something changes.
There was a problem hiding this comment.
Thanks, let me try the hybrid solution next.
ycombinator
force-pushed
the
mb-es-xp-index-mark-hidden
branch
from
c07c160 to
87b73dd
Compare
urso
approved these changes
Jul 8, 2020
|
CI failures are unrelated. See #19740. |
ycombinator
added
needs_backport
ycombinator
added a commit
that referenced
this pull request
Jul 9, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
* Report index hidden setting in index stats * Adding CHANGELOG entry * Use expand_wildcards in tests as well * Using json.Unmarshaler instead * Hybrid approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enhances the
elasticsearch/indexmetricset to report if an index is hidden or not.Why is it important?
This will allow the Stack Monitoring UI to suitably mark the index in the UI.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues