Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] Update googlecloud stackdriver metricset documentation #18693

Merged
merged 2 commits into from
May 27, 2020
Merged

[Metricbeat] Update googlecloud stackdriver metricset documentation #18693

merged 2 commits into from
May 27, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

This PR is to update stackdriver metricset documentation to include the full list of metric types and aggregation aligners.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 21, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this May 21, 2020
@kaiyan-sheng kaiyan-sheng added needs_backport PR is waiting to be backported to other branches. review Team:Platforms Label for the Integrations - Platforms team and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 21, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18693 updated]

  • Start Time: 2020-05-26T13:16:05.797+0000

  • Duration: 21 min 2 sec

@kaiyan-sheng kaiyan-sheng mentioned this pull request May 21, 2020
Closed
6 tasks
@kaiyan-sheng kaiyan-sheng requested a review from sorantis May 26, 2020 02:25
@sorantis sorantis changed the title [Filebeat] Update googlecloud stackdriver metricset documentation [Metricbeat] Update googlecloud stackdriver metricset documentation May 26, 2020
sorantis
sorantis reviewed May 26, 2020
View reviewed changes
Copy link
Contributor

@sorantis sorantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I had just one question before it's good to go!

x-pack/metricbeat/module/googlecloud/stackdriver/_meta/docs.asciidoc Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 26, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user kaiyan-sheng, Replayed #1]

  • Start Time: 2020-05-26T23:36:00.968+0000

  • Duration: 21 min 8 sec

@kaiyan-sheng kaiyan-sheng requested a review from sorantis May 26, 2020 23:35
@kaiyan-sheng kaiyan-sheng merged commit 4ccafd9 into elastic:master May 27, 2020
@kaiyan-sheng kaiyan-sheng deleted the gcp_doc branch May 27, 2020 13:26
@kaiyan-sheng kaiyan-sheng mentioned this pull request May 27, 2020
Merged
@kaiyan-sheng kaiyan-sheng added v7.9.0 and removed needs_backport PR is waiting to be backported to other branches. labels May 27, 2020
@kaiyan-sheng kaiyan-sheng mentioned this pull request May 27, 2020
Merged
kaiyan-sheng added a commit that referenced this pull request May 27, 2020
@kaiyan-sheng
[Metricbeat] Update googlecloud stackdriver metricset documentation (#…
7f3db89 
…18693) (#18779)

* Update googlecloud stackdriver metricset documentation

(cherry picked from commit 4ccafd9)
kaiyan-sheng added a commit that referenced this pull request May 27, 2020
@kaiyan-sheng
[Metricbeat] Update googlecloud stackdriver metricset documentation (#…
f3f36be 
…18693) (#18778)

* Update googlecloud stackdriver metricset documentation

(cherry picked from commit 4ccafd9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorantis sorantis sorantis approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
review Team:Platforms Label for the Integrations - Platforms team v7.8.0 v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaiyan-sheng @elasticmachine @sorantis @andresrc